the-distro/infra
8
1
Fork 8
Code Issues 37 Pull requests 9 Projects Releases Packages Wiki Activity Actions

Code review tooling for the monorepo #3

New issue
Closed
opened 2024-07-01 17:18:13 +00:00 by delroth · 5 comments
delroth commented 2024-07-01 17:18:13 +00:00
Owner
Copy link

Might be handled along with #1 if using Gerrit for both.

Might be handled along with #1 if using Gerrit for both.
raito was assigned by delroth 2024-07-04 02:48:31 +00:00
raito commented 2024-07-08 14:13:04 +00:00
Owner
Copy link

TODO:

  • Plug minimum role mapping (#35) into Gerrit.
  • Plug initial policies: +2/+1/-1/-2 into nixpkgs, code owners, etc.
  • Draw the outline to insert CI automation into Gerrit, e.g. all that is GHA should be replaced by… something?
TODO: - Plug minimum role mapping (#35) into Gerrit. - Plug initial policies: +2/+1/-1/-2 into nixpkgs, code owners, etc. - Draw the outline to insert CI automation into Gerrit, e.g. all that is GHA should be replaced by… something?
raito commented 2024-07-10 17:21:03 +00:00
Owner
Copy link

Basic CI automation:

Staging workflow:

  • Periodic merge
    • master → haskell-updates
    • release-24.05 → staging-next-24.05
    • staging-next-24.05 → staging-24.05
    • master → staging-next (every 6h)
    • staging-next → staging (every 6h)

More involved:

Misc and weird:

Basic CI automation: - [Release checks](https://github.com/NixOS/nixpkgs/blob/master/.github/workflows/basic-eval.yml) - [EditorConfig](https://github.com/NixOS/nixpkgs/blob/master/.github/workflows/editorconfig.yml) - [Build NixOS manual](https://github.com/NixOS/nixpkgs/blob/master/.github/workflows/manual-nixos.yml) - [Build Nixpkgs manual](https://github.com/NixOS/nixpkgs/blob/master/.github/workflows/manual-nixpkgs.yml) - [Build Nixpkgs shell](https://github.com/NixOS/nixpkgs/blob/master/.github/workflows/check-shell.yml) - [Check formatting](https://github.com/NixOS/nixpkgs/blob/master/.github/workflows/check-nix-format.yml) - [Check sortedness of maintainer-list](https://github.com/NixOS/nixpkgs/blob/master/.github/workflows/check-maintainers-sorted.yaml) - [Check alleged cherry-picks](https://github.com/NixOS/nixpkgs/blob/master/.github/workflows/check-cherry-picks.yml) - [Verify parseability of Nix files](https://github.com/NixOS/nixpkgs/blob/master/.github/workflows/nix-parse.yml) - [Block merge to channel branches](https://github.com/NixOS/nixpkgs/blob/master/.github/workflows/no-channel.yml): can be implemented as a hook Staging workflow: - [Periodic merge](https://github.com/NixOS/nixpkgs/blob/master/.github/workflows/periodic-merge-24h.yml) - master → haskell-updates - release-24.05 → staging-next-24.05 - staging-next-24.05 → staging-24.05 - master → staging-next (every 6h) - staging-next → staging (every 6h) More involved: - [Automatic labeller](https://github.com/NixOS/nixpkgs/blob/master/.github/workflows/labels.yml): https://github.com/NixOS/nixpkgs/blob/master/.github/labeler.yml - [OfBorg](https://github.com/NixOS/nixpkgs/blob/master/.github/workflows/ofborg-pending.yml) -- may not be necessary anymore - [Check pkgs/by-name hierarchy](https://github.com/NixOS/nixpkgs/blob/master/.github/workflows/check-by-name.yml) - [Backport action](https://github.com/NixOS/nixpkgs/blob/master/.github/workflows/backport.yml) Misc and weird: - [Update Terraform providers](https://github.com/NixOS/nixpkgs/blob/master/.github/workflows/update-terraform-providers.yml)
raito commented 2024-07-10 17:55:35 +00:00
Owner
Copy link

Labels added: https://cl.forkos.org/c/nixpkgs/+/62.

Labels added: https://cl.forkos.org/c/nixpkgs/+/62.
raito commented 2024-07-10 18:01:40 +00:00
Owner
Copy link

Proposal for group hierarchy for now:

  • Registered users are "maintainers", e.g. free to open any CLs, etc, push stuff to their sandbox branches.
  • Developers are the new committers, commit access to the whole repository.
  • Infrastructure are infrastructure developers, commit access to the infra repository (if it goes on Gerrit, uncertain).
  • Administrators are Gerrit admins.

Later on, I'd like to introduce proper code owners, and they do not have to be Developers per se.

Proposal for group hierarchy for now: - Registered users are "maintainers", e.g. free to open any CLs, etc, push stuff to their sandbox branches. - Developers are the new committers, commit access to the whole repository. - Infrastructure are infrastructure developers, commit access to the infra repository (if it goes on Gerrit, uncertain). - Administrators are Gerrit admins. Later on, I'd like to introduce proper code owners, and they do not have to be Developers per se.
emilylange referenced this issue from a commit 2025-05-10 20:56:20 +00:00
feat(buildbot)!: drop
emilylange referenced this issue from a commit 2025-05-10 21:00:17 +00:00
feat(buildbot)!: drop
raito commented 2025-08-24 00:34:07 +00:00
Owner
Copy link

The Floral project will not be tracked anymore here and is not the priority of AFNix for the immediate future.

The Floral project will not be tracked anymore here and is not the priority of AFNix for the immediate future.
raito closed this issue 2025-08-24 00:34:07 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
broker-flows
goaccess
alerting-to-zulip
better-backup-monitoring
forgejo-runners-sprinkles
abm
afnix-social-logins
hyp01
benchmarks
afnix-oidc
voidlinux-tenant
x86_builder_v6_only
besadii-release-branches
tom-hubrecht/audit
repair-ofborg
i-wish-i-had-jj-and-gerrit
scheduled-builds
gerrit-hydra
single-node-ceph
storage-project
cache-lix
email-groups
format
No results found.
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Difficulty
Architectural
Requires changes in multiple pieces of the stack: the Nix interpreter, etc.

  
Difficulty
Easy
Infrastructure beginner friendly tasks

  
Difficulty
Hard
Requires prior knowledge, research and design

  
Help Wanted

Looking for a first task to pick? This one is looking for somefew to do it as well!

  
Kind
Bug
Something is not working

  
Kind
Documentation
Documentation changes

  
Kind
Enhancement
Improve existing functionality

  
Kind
Feature
New functionality

  
Kind
Testing
Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Security

This is a security issue

  
Silenced Alert

This issue was created to track a silenced alert which needs remediation work.

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Status
Postponed
We can do this later

  
Tracking Issue

Umbrella issue of many things at the same time

No labels
Compat/Breaking
Difficulty
Architectural
Difficulty
Easy
Difficulty
Hard
Help Wanted
Kind
Bug
Kind
Documentation
Kind
Enhancement
Kind
Feature
Kind
Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Security
Silenced Alert
Status
Abandoned
Status
Blocked
Status
Need More Info
Status
Postponed
Tracking Issue
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Bootstrap infra
Assignees
Clear assignees
No assignees
raito
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: the-distro/infra#3
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?