the-distro/infra
9
0
Fork 5
Code Issues 38 Pull requests 6 Projects 1 Releases Packages Wiki Activity

feat(gerrit): run git-gc-preserve on a daily timer #110

Merged
raito merged 1 commit from gerrit-gc into main 2024-09-28 20:13:42 +00:00
Conversation 1 Commits 1 Files changed 2 +94
janik commented 2024-09-16 17:54:19 +00:00
Owner
Copy link
No description provided.
janik added 1 commit 2024-09-16 17:54:24 +00:00
janik requested review from raito 2024-09-16 17:54:32 +00:00
janik commented 2024-09-16 17:54:52 +00:00
Author
Owner
Copy link

fwiw: I didn't apply it yet

fwiw: I didn't apply it yet
janik force-pushed gerrit-gc from 09af4dfb7c to e5e578711c 2024-09-16 21:57:31 +00:00 Compare
raito reviewed 2024-09-17 14:52:01 +00:00
services/gerrit/git-gc-preserve.nix Outdated
@ -0,0 +83,4 @@
};
};
mkTimer = lib.mapAttrs' mkGCTimer;
enabledTimers = lib.filterAttrs (_: gcConfig: gcConfig.timerConfig != null) cfg;
raito commented 2024-09-17 14:52:01 +00:00
Owner
Copy link

do we plan to have no timer but services? enabledTimers sounds like gcConfig.enable to me again

do we plan to have no timer but services? enabledTimers sounds like `gcConfig.enable` to me again
janik commented 2024-09-17 16:31:22 +00:00
Author
Owner
Copy link

I honestly don't know, I can remove it if you think it doesn't give any benefit.

I honestly don't know, I can remove it if you think it doesn't give any benefit.
raito commented 2024-09-18 14:21:23 +00:00
Owner
Copy link

I think let's keep it simple: gcConfig.enable

I think let's keep it simple: `gcConfig.enable`
janik commented 2024-09-18 20:29:34 +00:00
Author
Owner
Copy link

Done, feel free to merge if you think it looks good.

Done, feel free to merge if you think it looks good.
janik marked this conversation as resolved
janik force-pushed gerrit-gc from e5e578711c to d462e8ca9c 2024-09-18 20:28:54 +00:00 Compare
raito merged commit c86cefe21f into main 2024-09-28 20:13:42 +00:00
janik deleted branch gerrit-gc 2024-09-28 20:14:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
raito
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: the-distro/infra#110
No description provided.
Delete branch "gerrit-gc"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?