forked from lix-project/lix
eldritch horrors
e6cd67591b
this gives about 20% performance improvements on pure parsing. obviously
it will be less on full eval, but depending on how much parsing is to be
done (e.g. including hackage-packages.nix or not) it's more like 4%-10%.
this has been tested (with thousands of core hours of fuzzing) to ensure
that the ASTs produced by the new parser are exactly the same as the old
one would have produced. error messages will change (sometimes by a lot)
and are not yet perfect, but we would rather leave this as is for later.
test results for running only the parser (excluding the variable binding
code) in a tight loop with inputs and parameters as given are promising:
- 40% faster on lix's package.nix at 10000 iterations
- 1.3% faster on nixpkgs all-packages.nix at 1000 iterations
- equivalent on all of nixpkgs concatenated at 100 iterations
(excluding invalid files, each file surrounded with parens)
more realistic benchmarks are somewhere in between the extremes, parsing
once again getting the largest uplift. other realistic workloads improve
by a few percentage points as well, notably system builds are 4% faster.
Benchmarks summary (from ./bench/summarize.jq bench/bench-*.json)
old/bin/nix --extra-experimental-features 'nix-command flakes' eval -f bench/nixpkgs/pkgs/development/haskell-modules/hackage-packages.nix
mean: 0.408s ± 0.025s
user: 0.355s | system: 0.033s
median: 0.389s
range: 0.388s ... 0.442s
relative: 1
new/bin/nix --extra-experimental-features 'nix-command flakes' eval -f bench/nixpkgs/pkgs/development/haskell-modules/hackage-packages.nix
mean: 0.332s ± 0.024s
user: 0.279s | system: 0.033s
median: 0.314s
range: 0.313s ... 0.361s
relative: 0.814
---
old/bin/nix --extra-experimental-features 'nix-command flakes' eval --raw --impure --expr 'with import <nixpkgs/nixos> {}; system'
mean: 6.133s ± 0.022s
user: 5.395s | system: 0.437s
median: 6.128s
range: 6.099s ... 6.183s
relative: 1
new/bin/nix --extra-experimental-features 'nix-command flakes' eval --raw --impure --expr 'with import <nixpkgs/nixos> {}; system'
mean: 5.925s ± 0.025s
user: 5.176s | system: 0.456s
median: 5.934s
range: 5.861s ... 5.943s
relative: 0.966
---
GC_INITIAL_HEAP_SIZE=10g old/bin/nix eval --extra-experimental-features 'nix-command flakes' --raw --impure --expr 'with import <nixpkgs/nixos> {}; system'
mean: 4.503s ± 0.027s
user: 3.731s | system: 0.547s
median: 4.499s
range: 4.478s ... 4.541s
relative: 1
GC_INITIAL_HEAP_SIZE=10g new/bin/nix eval --extra-experimental-features 'nix-command flakes' --raw --impure --expr 'with import <nixpkgs/nixos> {}; system'
mean: 4.285s ± 0.031s
user: 3.504s | system: 0.571s
median: 4.281s
range: 4.221s ... 4.328s
relative: 0.951
---
old/bin/nix --extra-experimental-features 'nix-command flakes' search --no-eval-cache github:nixos/nixpkgs/e1fa12d4f6c6fe19ccb59cac54b5b3f25e160870 hello
mean: 16.475s ± 0.07s
user: 14.088s | system: 1.572s
median: 16.495s
range: 16.351s ... 16.536s
relative: 1
new/bin/nix --extra-experimental-features 'nix-command flakes' search --no-eval-cache github:nixos/nixpkgs/e1fa12d4f6c6fe19ccb59cac54b5b3f25e160870 hello
mean: 15.973s ± 0.013s
user: 13.558s | system: 1.615s
median: 15.973s
range: 15.946s ... 15.99s
relative: 0.97
---
Change-Id:
|
||
|---|---|---|
| .. | ||
| ca | ||
| common | ||
| config | ||
| dyn-drv | ||
| flakes | ||
| lang | ||
| nested-sandboxing | ||
| plugins | ||
| repl_characterization | ||
| test-libstoreconsumer | ||
| add.sh | ||
| bad.tar.xz | ||
| bash-profile.sh | ||
| big-derivation-attr.nix | ||
| binary-cache-build-remote.sh | ||
| binary-cache.sh | ||
| brotli.sh | ||
| build-delete.sh | ||
| build-dry.sh | ||
| build-hook-ca-fixed.nix | ||
| build-hook-ca-floating.nix | ||
| build-hook.nix | ||
| build-remote-content-addressed-fixed.sh | ||
| build-remote-content-addressed-floating.sh | ||
| build-remote-input-addressed.sh | ||
| build-remote-trustless-after.sh | ||
| build-remote-trustless-should-fail-0.sh | ||
| build-remote-trustless-should-pass-0.sh | ||
| build-remote-trustless-should-pass-1.sh | ||
| build-remote-trustless-should-pass-2.sh | ||
| build-remote-trustless-should-pass-3.sh | ||
| build-remote-trustless.sh | ||
| build-remote.sh | ||
| build.sh | ||
| ca-shell.nix | ||
| case-hack.sh | ||
| case.nar | ||
| check-refs.nix | ||
| check-refs.sh | ||
| check-reqs.nix | ||
| check-reqs.sh | ||
| check.nix | ||
| check.sh | ||
| common.sh | ||
| completions.sh | ||
| compression-levels.sh | ||
| compute-levels.sh | ||
| config.nix.in | ||
| config.sh | ||
| db-migration.sh | ||
| debugger.sh | ||
| dependencies.builder0.sh | ||
| dependencies.nix | ||
| dependencies.sh | ||
| derivation-json.sh | ||
| dummy | ||
| dump-db.sh | ||
| eval-store.sh | ||
| eval.nix | ||
| eval.sh | ||
| experimental-features.sh | ||
| export-graph.nix | ||
| export-graph.sh | ||
| export.sh | ||
| extra-sandbox-profile.nix | ||
| extra-sandbox-profile.sh | ||
| failing.nix | ||
| fetchClosure.sh | ||
| fetchGit.sh | ||
| fetchGitRefs.sh | ||
| fetchGitSubmodules.sh | ||
| fetchMercurial.sh | ||
| fetchPath.sh | ||
| fetchTree-file.sh | ||
| fetchurl.sh | ||
| filter-source.nix | ||
| filter-source.sh | ||
| fixed.builder1.sh | ||
| fixed.builder2.sh | ||
| fixed.nix | ||
| fixed.sh | ||
| fmt.sh | ||
| fmt.simple.sh | ||
| fod-failing.nix | ||
| function-trace.sh | ||
| gc-auto.sh | ||
| gc-concurrent.builder.sh | ||
| gc-concurrent.nix | ||
| gc-concurrent.sh | ||
| gc-concurrent2.builder.sh | ||
| gc-non-blocking.sh | ||
| gc-runtime.nix | ||
| gc-runtime.sh | ||
| gc.sh | ||
| hash-check.nix | ||
| hash.sh | ||
| hermetic.nix | ||
| ifd.nix | ||
| import-derivation.nix | ||
| import-derivation.sh | ||
| impure-derivations.nix | ||
| impure-derivations.sh | ||
| impure-eval.sh | ||
| init.sh | ||
| install-darwin.sh | ||
| lang-test-infra.sh | ||
| lang.sh | ||
| legacy-ssh-store.sh | ||
| linux-sandbox-cert-test.nix | ||
| linux-sandbox.sh | ||
| local-store.sh | ||
| logging.sh | ||
| meson.build | ||
| misc.sh | ||
| multiple-outputs.nix | ||
| multiple-outputs.sh | ||
| nar-access.nix | ||
| nar-access.sh | ||
| nested-sandboxing.sh | ||
| nix-build-examples.nix | ||
| nix-build.sh | ||
| nix-channel.sh | ||
| nix-collect-garbage-d.sh | ||
| nix-copy-ssh-common.sh | ||
| nix-copy-ssh-ng.sh | ||
| nix-copy-ssh.sh | ||
| nix-daemon-untrusting.sh | ||
| nix-profile.sh | ||
| nix-shell.sh | ||
| nix_path.sh | ||
| optimise-store.sh | ||
| output-normalization.sh | ||
| parallel.builder.sh | ||
| parallel.nix | ||
| parallel.sh | ||
| pass-as-file.sh | ||
| path-from-hash-part.sh | ||
| path.nix | ||
| placeholders.sh | ||
| plugins.sh | ||
| post-hook.sh | ||
| pure-eval.nix | ||
| pure-eval.sh | ||
| push-to-store-old.sh | ||
| push-to-store.sh | ||
| read-only-store.sh | ||
| readfile-context.nix | ||
| readfile-context.sh | ||
| recursive.nix | ||
| recursive.sh | ||
| referrers.sh | ||
| remote-store.sh | ||
| repair.sh | ||
| repl.sh | ||
| restricted.nix | ||
| restricted.sh | ||
| search.nix | ||
| search.sh | ||
| secure-drv-outputs.nix | ||
| secure-drv-outputs.sh | ||
| selfref-gc.sh | ||
| shell-hello.nix | ||
| shell.nix | ||
| shell.sh | ||
| shell.shebang.nix | ||
| shell.shebang.rb | ||
| shell.shebang.sh | ||
| signing.sh | ||
| simple-failing.nix | ||
| simple.builder.sh | ||
| simple.nix | ||
| simple.sh | ||
| ssh-relay.sh | ||
| store-ping.sh | ||
| structured-attrs-shell.nix | ||
| structured-attrs.nix | ||
| structured-attrs.sh | ||
| substitute-truncated-nar.sh | ||
| substitute-with-invalid-ca.sh | ||
| suggestions.sh | ||
| supplementary-groups.sh | ||
| symlink-derivation.nix | ||
| tarball.sh | ||
| test-infra.sh | ||
| test-libstoreconsumer.sh | ||
| test-repl-characterization.sh | ||
| timeout.nix | ||
| timeout.sh | ||
| toString-path.sh | ||
| undefined-variable.nix | ||
| user-envs-migration.sh | ||
| user-envs.builder.sh | ||
| user-envs.nix | ||
| user-envs.sh | ||
| why-depends.sh | ||
| zstd.sh | ||