soenkehahn/lix
0
0
Fork 0
forked from lix-project/lix
Code Pull requests Activity

nix search: fix bug where we wrote to cache when shouldn't, breaking

Browse source 
This is exposed by the tests added previously,
and resolves the error reported in #1892:
"expected JSON value".
This commit is contained in:
Will Dietz 2018-02-25 16:32:36 -06:00
parent 8282c60d74
commit 3cac8734ac
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/nix/search.cc
View file

@ -237,7 +237,7 @@ struct CmdSearch : SourceExprCommand, MixJSON
throw Error("error writing to %s", tmpFile); throw Error("error writing to %s", tmpFile);
} }
if (rename(tmpFile.c_str(), jsonCacheFileName.c_str()) == -1) if (writeCache && rename(tmpFile.c_str(), jsonCacheFileName.c_str()) == -1)
throw SysError("cannot rename '%s' to '%s'", tmpFile, jsonCacheFileName); throw SysError("cannot rename '%s' to '%s'", tmpFile, jsonCacheFileName);
} }
} }