snaakey/hydra
0
0
Fork 0
forked from lix-project/hydra
Code Pull requests Activity

Queue: Remove the scheduling priority

Browse source 
Scheduling is mostly based on jobset shares these days. So showing and
sorting by priority just wastes space and gives the incorrect
impression that Hydra executes builds in the order shown on the queue
page.
This commit is contained in:
Eelco Dolstra 2015-02-26 13:14:10 +01:00
parent 7f6faee08a
commit 62805dd73c
2 changed files with 1 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/lib/Hydra/Controller/Root.pm
View file

@ -88,7 +88,7 @@ sub queue_GET {
$c->stash->{flashMsg} //= $c->flash->{buildMsg}; $c->stash->{flashMsg} //= $c->flash->{buildMsg};
$self->status_ok( $self->status_ok(
$c, $c,
entity => [$c->model('DB::Builds')->search({finished => 0}, { order_by => ["priority DESC", "id"]})] entity => [$c->model('DB::Builds')->search({finished => 0}, { order_by => ["id"]})]
); );
} }

6
src/root/common.tt
View file

@ -78,9 +78,6 @@ BLOCK renderBuildListHeader %]
<th></th> <th></th>
[% END %] [% END %]
<th>#</th> <th>#</th>
[% IF showSchedulingInfo %]
<th>P</th>
[% END %]
[% IF !hideJobName %] [% IF !hideJobName %]
<th>Job</th> <th>Job</th>
[% END %] [% END %]
@ -108,9 +105,6 @@ BLOCK renderBuildListBody;
<td>[% IF build.busy %]<span class="label label-success">Started</span>[% ELSE %]<span class="label">Queued</span>[% END %]</td> <td>[% IF build.busy %]<span class="label label-success">Started</span>[% ELSE %]<span class="label">Queued</span>[% END %]</td>
[% END %] [% END %]
<td><a class="row-link" href="[% c.uri_for('/build' build.id) %]">[% build.id %]</a></td> <td><a class="row-link" href="[% c.uri_for('/build' build.id) %]">[% build.id %]</a></td>
[% IF showSchedulingInfo %]
<td>[% build.priority %]</td>
[% END %]
[% IF !hideJobName %] [% IF !hideJobName %]
<td>[% INCLUDE renderFullJobNameOfBuild %]</td> <td>[% INCLUDE renderFullJobNameOfBuild %]</td>
[% END %] [% END %]