snaakey/hydra
0
0
Fork 0
forked from lix-project/hydra
Code Pull requests Activity

t/TaskDispatcher.t: array / arrayref consistency

Browse source 
Also fixes a test which was comparing the length of two lists
instead of the values inside the lists. Dang, Perl.
This commit is contained in:
Graham Christensen 2021-10-19 22:38:50 -04:00
parent a5fa3fccc3
commit 43c056bb7b
1 changed files with 13 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
t/TaskDispatcher.t
View file

@ -87,24 +87,23 @@ sub make_fake_record {
subtest "dispatch_event" => sub { subtest "dispatch_event" => sub {
subtest "every plugin gets called once, even if it fails all of them." => sub { subtest "every plugin gets called once, even if it fails all of them." => sub {
my @plugins = [make_noop_plugin("bogus-1"), make_noop_plugin("bogus-2")]; my $plugins = [make_noop_plugin("bogus-1"), make_noop_plugin("bogus-2")];
my $dispatcher = Hydra::TaskDispatcher->new($db, $prometheus, @plugins); my $dispatcher = Hydra::TaskDispatcher->new($db, $prometheus, $plugins);
my $event = make_failing_event("bogus-channel"); my $event = make_failing_event("bogus-channel");
$dispatcher->dispatch_event($event); $dispatcher->dispatch_event($event);
is(@{$event->{"called_with"}}, 2, "Both plugins should be called"); is(@{$event->{"called_with"}}, 2, "Both plugins should be called");
my @expected_names = [ "bogus-1", "bogus-2" ]; my @expected_names = ( "bogus-1", "bogus-2" );
my @actual_names = sort([ my @actual_names = sort(
$event->{"called_with"}[0]->name, $event->{"called_with"}[0]->name,
$event->{"called_with"}[1]->name $event->{"called_with"}[1]->name
]); );
is( is(
@actual_names, \@actual_names,
@expected_names, \@expected_names,
"Both plugins should be executed, but not in any particular order." "Both plugins should be executed, but not in any particular order."
); );
}; };
@ -113,9 +112,9 @@ subtest "dispatch_event" => sub {
subtest "dispatch_task" => sub { subtest "dispatch_task" => sub {
subtest "every plugin gets called once" => sub { subtest "every plugin gets called once" => sub {
my $bogus_plugin = make_noop_plugin("bogus-1"); my $bogus_plugin = make_noop_plugin("bogus-1");
my @plugins = [$bogus_plugin, make_noop_plugin("bogus-2")]; my $plugins = [$bogus_plugin, make_noop_plugin("bogus-2")];
my $dispatcher = Hydra::TaskDispatcher->new($db, $prometheus, @plugins); my $dispatcher = Hydra::TaskDispatcher->new($db, $prometheus, $plugins);
my $event = make_fake_event("bogus-channel"); my $event = make_fake_event("bogus-channel");
my $task = Hydra::Task->new($event, ref $bogus_plugin); my $task = Hydra::Task->new($event, ref $bogus_plugin);
@ -132,9 +131,9 @@ subtest "dispatch_task" => sub {
subtest "a task with an invalid plugin is not fatal" => sub { subtest "a task with an invalid plugin is not fatal" => sub {
my $bogus_plugin = make_noop_plugin("bogus-1"); my $bogus_plugin = make_noop_plugin("bogus-1");
my @plugins = [$bogus_plugin, make_noop_plugin("bogus-2")]; my $plugins = [$bogus_plugin, make_noop_plugin("bogus-2")];
my $dispatcher = Hydra::TaskDispatcher->new($db, $prometheus, @plugins); my $dispatcher = Hydra::TaskDispatcher->new($db, $prometheus, $plugins);
my $event = make_fake_event("bogus-channel"); my $event = make_fake_event("bogus-channel");
my $task = Hydra::Task->new($event, "this-plugin-does-not-exist"); my $task = Hydra::Task->new($event, "this-plugin-does-not-exist");