forked from lix-project/lix
jade
9909a175bf
This was found when `logrotate.conf` failed to build in a NixOS system
with:
/nix/store/26zdl4pyw5qazppj8if5lm8bjzxlc07l-coreutils-9.3/bin/id: cannot find name for group ID 30000
This was surprising because it seemed to mean that /etc/group was busted
in the sandbox. Indeed it was:
root❌0:
nixbld:!💯
nogroup❌65534:
We diagnosed this to sandboxUid() being called before
usingUserNamespace() was called, in setting up /etc/group inside the
sandbox. This code desperately needs refactoring.
We also moved the /etc/group code to be with the /etc/passwd code, but
honestly this code is all spaghetti'd all over the place and needs some
more serious tidying than we did here.
We also moved some checks to be earlier to improve locality with where
the things they are checking come from.
Change-Id:
|
||
|---|---|---|
| .. | ||
| derivation-goal.cc | ||
| derivation-goal.hh | ||
| drv-output-substitution-goal.cc | ||
| drv-output-substitution-goal.hh | ||
| entry-points.cc | ||
| goal.cc | ||
| goal.hh | ||
| hook-instance.cc | ||
| hook-instance.hh | ||
| local-derivation-goal.cc | ||
| local-derivation-goal.hh | ||
| personality.cc | ||
| personality.hh | ||
| sandbox-defaults.sb | ||
| sandbox-minimal.sb | ||
| sandbox-network.sb | ||
| substitution-goal.cc | ||
| substitution-goal.hh | ||
| worker.cc | ||
| worker.hh | ||