jade
fdc980208d
Sample broken thing: https://buildbot.lix.systems/#/builders/40/builds/3400/steps/1/logs/stdio I have a suspicion it's that the path vanished due to GC or something, and I want to catch the next occurrence. The error: error: build of '/nix/store/f02iygmil30yfy92xf8cwp224lcr2nay-nixos-test-driver-nix-copy-closure.drv' on 'ssh-ng://nix@epyc.infra.newtype.fr' failed: error: some dependencies of '/nix/store/f02iygmil30yfy92xf8cwp224lcr2nay-nixos-test-driver-nix-copy-closure.drv' are missing This is because nrFailed is not zero, which we don't have any god damned idea why that is because there is NO LOG for those. So we don't even know what goal type failed to begin with. ---- WARNING: this updates nixpkgs by two months!! You will potentially experience other breakage.
41 lines
1.9 KiB
Diff
41 lines
1.9 KiB
Diff
From 96937c58232ad6eaa11d1370220101c3ce2d00c3 Mon Sep 17 00:00:00 2001
|
|
From: Jade Lovelace <lix@jade.fyi>
|
|
Date: Thu, 29 Aug 2024 23:04:39 -0700
|
|
Subject: [PATCH] wip: complain about failing goals at warn level
|
|
|
|
I want to fix the bug that appears here:
|
|
|
|
error: build of '/nix/store/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-nixos-test-driver-nix-copy-closure.drv' on 'ssh-ng://nix@epyc.infra.newtype.fr' failed: error: some dependencies of '/nix/store/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-nixos-test-driver-nix-copy-closure.drv' are missing
|
|
error: builder for '/nix/store/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-nixos-test-driver-nix-copy-closure.drv' failed with exit code 1
|
|
error: 1 dependencies of derivation '/nix/store/bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb-vm-test-run-nix-copy-closure.drv' failed to build
|
|
|
|
However, this is conditional on nrFailed, and I cannot for the life of
|
|
me figure out *who* is failing and *why*.
|
|
|
|
Hopefully with these data I can narrow down why this bug is happening
|
|
|
|
Change-Id: I7dca71b1c8ac92e7cc40c47ab37c952a7673cf42
|
|
---
|
|
src/libstore/build/worker.cc | 5 ++++-
|
|
1 file changed, 4 insertions(+), 1 deletion(-)
|
|
|
|
diff --git a/src/libstore/build/worker.cc b/src/libstore/build/worker.cc
|
|
index 1b4633e64..a93be28a6 100644
|
|
--- a/src/libstore/build/worker.cc
|
|
+++ b/src/libstore/build/worker.cc
|
|
@@ -160,7 +160,10 @@ void Worker::goalFinished(GoalPtr goal, Goal::Finished & f)
|
|
|
|
waiting->trace(fmt("waitee '%s' done; %d left", goal->name, waiting->waitees.size()));
|
|
|
|
- if (f.result != Goal::ecSuccess) ++waiting->nrFailed;
|
|
+ if (f.result != Goal::ecSuccess) {
|
|
+ ++waiting->nrFailed;
|
|
+ warn("Waiter %s experienced non-success of waitee %s with result %d", waiting->getName(), goal->getName(), f.result);
|
|
+ }
|
|
if (f.result == Goal::ecNoSubstituters) ++waiting->nrNoSubstituters;
|
|
if (f.result == Goal::ecIncompleteClosure) ++waiting->nrIncompleteClosure;
|
|
|
|
--
|
|
2.44.1
|
|
|