Remove the errorMsg column from the Builds table

The queue runner no longer uses this field, and it doesn't provide
very interesting historical data (mostly SSH failures), but it takes
up a lot of space. Also, it contained some bad UTF-8 which was
preventing an upgrade to Postgres 9.5, so a good occasion to get rid
of it.
This commit is contained in:
Eelco Dolstra 2016-02-12 17:21:55 +01:00
parent 5c5bb3762c
commit e46acbf05b
4 changed files with 4 additions and 17 deletions

View file

@ -170,11 +170,6 @@ __PACKAGE__->table("Builds");
data_type: 'integer' data_type: 'integer'
is_nullable: 1 is_nullable: 1
=head2 errormsg
data_type: 'text'
is_nullable: 1
=head2 size =head2 size
data_type: 'bigint' data_type: 'bigint'
@ -249,8 +244,6 @@ __PACKAGE__->add_columns(
{ data_type => "integer", is_nullable => 1 }, { data_type => "integer", is_nullable => 1 },
"buildstatus", "buildstatus",
{ data_type => "integer", is_nullable => 1 }, { data_type => "integer", is_nullable => 1 },
"errormsg",
{ data_type => "text", is_nullable => 1 },
"size", "size",
{ data_type => "bigint", is_nullable => 1 }, { data_type => "bigint", is_nullable => 1 },
"closuresize", "closuresize",
@ -544,8 +537,8 @@ __PACKAGE__->many_to_many(
); );
# Created by DBIx::Class::Schema::Loader v0.07043 @ 2015-10-27 13:54:16 # Created by DBIx::Class::Schema::Loader v0.07043 @ 2016-02-12 17:20:42
# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:iN9vwO5i3dURKOTgaPTHxw # DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:/8aVtXu/+o0jmKHnSzwt+g
__PACKAGE__->has_many( __PACKAGE__->has_many(
"dependents", "dependents",

View file

@ -280,11 +280,6 @@ FOR step IN steps; IF step.busy; busy = 1; END; END;
</table> </table>
[% END %] [% END %]
[% IF build.errormsg && build.buildstatus != 5 %]
<h2 id="nix-error">Nix error output</h2>
<pre class="buildlog">[% HTML.escape(build.errormsg) %]</pre>
[% END %]
[% END %] [% END %]
</div> </div>

View file

@ -184,7 +184,7 @@ create table Builds (
-- 0 = succeeded -- 0 = succeeded
-- 1 = build of this derivation failed -- 1 = build of this derivation failed
-- 2 = build of some dependency failed -- 2 = build of some dependency failed
-- 3 = other failure (see errorMsg) -- 3 = other failure
-- 4 = build cancelled (removed from queue; never built) -- 4 = build cancelled (removed from queue; never built)
-- 5 = build not done because a dependency failed previously (obsolete) -- 5 = build not done because a dependency failed previously (obsolete)
-- 6 = failure with output -- 6 = failure with output
@ -193,8 +193,6 @@ create table Builds (
-- 10 = log limit exceeded -- 10 = log limit exceeded
buildStatus integer, buildStatus integer,
errorMsg text, -- error message in case of a Nix failure
size bigint, size bigint,
closureSize bigint, closureSize bigint,

1
src/sql/upgrade-44.sql Normal file
View file

@ -0,0 +1 @@
alter table Builds drop column errorMsg;