From 8e408048e2c10c1e9e33797ae2bf576bb15f11c0 Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Fri, 19 Jun 2015 11:33:15 +0200 Subject: [PATCH] Create build step for non-top-level cached failures This fixes the missing build step on failures like http://hydra.nixos.org/build/23222231 --- src/hydra-queue-runner/hydra-queue-runner.cc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/hydra-queue-runner/hydra-queue-runner.cc b/src/hydra-queue-runner/hydra-queue-runner.cc index c2a1fdd4..498297fc 100644 --- a/src/hydra-queue-runner/hydra-queue-runner.cc +++ b/src/hydra-queue-runner/hydra-queue-runner.cc @@ -1224,8 +1224,9 @@ bool State::doBuildStep(std::shared_ptr store, Step::ptr step, (otherwise the user won't be able to see what caused the build to fail). */ for (auto & build2 : indirect) { - if (build == build2) continue; - if (cachedFailure && build2->drvPath == step->drvPath) continue; + if ((cachedFailure && build2->drvPath == step->drvPath) || + (!cachedFailure && build == build2)) + continue; createBuildStep(txn, 0, build2, step, machine->sshName, buildStepStatus, result.errorMsg, build->id); }