From 7704118d2816c2f7939db6771cd4665d5a68596d Mon Sep 17 00:00:00 2001
From: Eelco Dolstra <edolstra@gmail.com>
Date: Tue, 21 Mar 2023 12:59:37 +0100
Subject: [PATCH] nix describe-stores: Remove

This command was intended for docs generation, but it was never used
for that and we don't need it.
---
 doc/manual/src/release-notes/rl-next.md |  4 ++-
 src/nix/describe-stores.cc              | 44 -------------------------
 tests/describe-stores.sh                |  8 -----
 tests/local.mk                          |  1 -
 4 files changed, 3 insertions(+), 54 deletions(-)
 delete mode 100644 src/nix/describe-stores.cc
 delete mode 100644 tests/describe-stores.sh

diff --git a/doc/manual/src/release-notes/rl-next.md b/doc/manual/src/release-notes/rl-next.md
index b8d14e605..3e6bfe3e0 100644
--- a/doc/manual/src/release-notes/rl-next.md
+++ b/doc/manual/src/release-notes/rl-next.md
@@ -26,4 +26,6 @@
   ```shell-session
   $ nix path-info /nix/store/gzaflydcr6sb3567hap9q6srzx8ggdgg-glibc-2.33-78.drv^*
   ```
-  provides information about each of its outputs.
\ No newline at end of file
+  provides information about each of its outputs.
+
+* The command `nix describe-stores` has been removed.
diff --git a/src/nix/describe-stores.cc b/src/nix/describe-stores.cc
deleted file mode 100644
index ad6b2f0f8..000000000
--- a/src/nix/describe-stores.cc
+++ /dev/null
@@ -1,44 +0,0 @@
-#include "command.hh"
-#include "common-args.hh"
-#include "shared.hh"
-#include "store-api.hh"
-
-#include <nlohmann/json.hpp>
-
-using namespace nix;
-
-struct CmdDescribeStores : Command, MixJSON
-{
-    std::string description() override
-    {
-        return "show registered store types and their available options";
-    }
-
-    Category category() override { return catUtility; }
-
-    void run() override
-    {
-        auto res = nlohmann::json::object();
-        for (auto & implem : *Implementations::registered) {
-            auto storeConfig = implem.getConfig();
-            auto storeName = storeConfig->name();
-            res[storeName]["settings"] = storeConfig->toJSON();
-        }
-        if (json) {
-            logger->cout("%s", res);
-        } else {
-            for (auto & [storeName, storeConfig] : res.items()) {
-                std::cout << "## " << storeName << std::endl << std::endl;
-                for (auto & [optionName, optionDesc] : storeConfig.items()) {
-                    std::cout << "### " << optionName << std::endl << std::endl;
-                    std::cout << optionDesc["description"].get<std::string>() << std::endl;
-                    std::cout << "default: " << optionDesc["defaultValue"] << std::endl <<std::endl;
-                    if (!optionDesc["aliases"].empty())
-                        std::cout << "aliases: " << optionDesc["aliases"] << std::endl << std::endl;
-                }
-            }
-        }
-    }
-};
-
-static auto rDescribeStore = registerCommand<CmdDescribeStores>("describe-stores");
diff --git a/tests/describe-stores.sh b/tests/describe-stores.sh
deleted file mode 100644
index 3fea61483..000000000
--- a/tests/describe-stores.sh
+++ /dev/null
@@ -1,8 +0,0 @@
-source common.sh
-
-# Query an arbitrary value in `nix describe-stores --json`'s output just to
-# check that it has the right structure
-[[ $(nix --experimental-features 'nix-command flakes' describe-stores --json | jq '.["SSH Store"]["compress"]["defaultValue"]') == false ]]
-
-# Ensure that the output of `nix describe-stores` isn't empty
-[[ -n $(nix --experimental-features 'nix-command flakes' describe-stores) ]]
diff --git a/tests/local.mk b/tests/local.mk
index 328f27e90..c6c728a86 100644
--- a/tests/local.mk
+++ b/tests/local.mk
@@ -115,7 +115,6 @@ nix_tests = \
   db-migration.sh \
   bash-profile.sh \
   pass-as-file.sh \
-  describe-stores.sh \
   nix-profile.sh \
   suggestions.sh \
   store-ping.sh \