qyriad/lix
1
0
Fork 0
forked from lix-project/lix
Code Pull requests Activity

Enable toLower umlauts test

Browse source 
Update comment and enable the test
This commit is contained in:
Tobias Pflug 2020-05-08 15:13:55 +02:00
parent 2191141274
commit 181a47d884
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/libutil/tests/tests.cc
View file

@ -301,12 +301,12 @@ namespace nix {
ASSERT_EQ(toLower(s), s); ASSERT_EQ(toLower(s), s);
} }
// XXX: std::tolower() doesn't cover this. This probably doesn't matter // std::tolower() doesn't handle unicode characters. In the context of
// since the context is paths and store paths specifically where such // store paths this isn't relevant but doesn't hurt to record this behavior
// characters are not allowed. // here.
TEST(toLower, DISABLED_umlauts) { TEST(toLower, umlauts) {
auto s = "ÄÖÜ"; auto s = "ÄÖÜ";
ASSERT_EQ(toLower(s), "äöü"); ASSERT_EQ(toLower(s), "ÄÖÜ");
} }
/* ---------------------------------------------------------------------------- /* ----------------------------------------------------------------------------