qyriad/lix
1
0
Fork 0
forked from lix-project/lix
Code Pull requests Activity
lix/src/libstore/parsed-derivations.hh

38 lines
784 B
C++
Raw Normal View History

Move structured attrs handling into a separate class This is primarily because Derivation::{can,will}BuildLocally() depends on attributes like preferLocalBuild and requiredSystemFeatures, but it can't handle them properly because it doesn't have access to the structured attributes.
2018-09-28 12:31:16 +00:00
#include "derivations.hh"
#include <nlohmann/json.hpp>
namespace nix {
class ParsedDerivation
{
Make the Store API more type-safe Most functions now take a StorePath argument rather than a Path (which is just an alias for std::string). The StorePath constructor ensures that the path is syntactically correct (i.e. it looks like <store-dir>/<base32-hash>-<name>). Similarly, functions like buildPaths() now take a StorePathWithOutputs, rather than abusing Path by adding a '!<outputs>' suffix. Note that the StorePath type is implemented in Rust. This involves some hackery to allow Rust values to be used directly in C++, via a helper type whose destructor calls the Rust type's drop() function. The main issue is the dynamic nature of C++ move semantics: after we have moved a Rust value, we should not call the drop function on the original value. So when we move a value, we set the original value to bitwise zero, and the destructor only calls drop() if the value is not bitwise zero. This should be sufficient for most types. Also lots of minor cleanups to the C++ API to make it more modern (e.g. using std::optional and std::string_view in some places).
2019-12-05 18:11:09 +00:00
StorePath drvPath;
Move structured attrs handling into a separate class This is primarily because Derivation::{can,will}BuildLocally() depends on attributes like preferLocalBuild and requiredSystemFeatures, but it can't handle them properly because it doesn't have access to the structured attributes.
2018-09-28 12:31:16 +00:00
BasicDerivation & drv;
experimental/optional -> optional
2019-02-12 12:43:32 +00:00
std::optional<nlohmann::json> structuredAttrs;
Move structured attrs handling into a separate class This is primarily because Derivation::{can,will}BuildLocally() depends on attributes like preferLocalBuild and requiredSystemFeatures, but it can't handle them properly because it doesn't have access to the structured attributes.
2018-09-28 12:31:16 +00:00
public:
Make the Store API more type-safe Most functions now take a StorePath argument rather than a Path (which is just an alias for std::string). The StorePath constructor ensures that the path is syntactically correct (i.e. it looks like <store-dir>/<base32-hash>-<name>). Similarly, functions like buildPaths() now take a StorePathWithOutputs, rather than abusing Path by adding a '!<outputs>' suffix. Note that the StorePath type is implemented in Rust. This involves some hackery to allow Rust values to be used directly in C++, via a helper type whose destructor calls the Rust type's drop() function. The main issue is the dynamic nature of C++ move semantics: after we have moved a Rust value, we should not call the drop function on the original value. So when we move a value, we set the original value to bitwise zero, and the destructor only calls drop() if the value is not bitwise zero. This should be sufficient for most types. Also lots of minor cleanups to the C++ API to make it more modern (e.g. using std::optional and std::string_view in some places).
2019-12-05 18:11:09 +00:00
ParsedDerivation(StorePath && drvPath, BasicDerivation & drv);
Move structured attrs handling into a separate class This is primarily because Derivation::{can,will}BuildLocally() depends on attributes like preferLocalBuild and requiredSystemFeatures, but it can't handle them properly because it doesn't have access to the structured attributes.
2018-09-28 12:31:16 +00:00
experimental/optional -> optional
2019-02-12 12:43:32 +00:00
const std::optional<nlohmann::json> & getStructuredAttrs() const
Move structured attrs handling into a separate class This is primarily because Derivation::{can,will}BuildLocally() depends on attributes like preferLocalBuild and requiredSystemFeatures, but it can't handle them properly because it doesn't have access to the structured attributes.
2018-09-28 12:31:16 +00:00
{
return structuredAttrs;
}
experimental/optional -> optional
2019-02-12 12:43:32 +00:00
std::optional<std::string> getStringAttr(const std::string & name) const;
Move structured attrs handling into a separate class This is primarily because Derivation::{can,will}BuildLocally() depends on attributes like preferLocalBuild and requiredSystemFeatures, but it can't handle them properly because it doesn't have access to the structured attributes.
2018-09-28 12:31:16 +00:00
bool getBoolAttr(const std::string & name, bool def = false) const;
experimental/optional -> optional
2019-02-12 12:43:32 +00:00
std::optional<Strings> getStringsAttr(const std::string & name) const;
Move structured attrs handling into a separate class This is primarily because Derivation::{can,will}BuildLocally() depends on attributes like preferLocalBuild and requiredSystemFeatures, but it can't handle them properly because it doesn't have access to the structured attributes.
2018-09-28 12:31:16 +00:00
Check requiredSystemFeatures for local builds For example, this prevents a "kvm" build on machines that don't have KVM. Fixes #2012.
2018-09-28 13:57:27 +00:00
StringSet getRequiredSystemFeatures() const;
Move structured attrs handling into a separate class This is primarily because Derivation::{can,will}BuildLocally() depends on attributes like preferLocalBuild and requiredSystemFeatures, but it can't handle them properly because it doesn't have access to the structured attributes.
2018-09-28 12:31:16 +00:00
bool canBuildLocally() const;
bool willBuildLocally() const;
Support allowSubstitutes attribute in structured attribute derivations Hopefully fixes #3081 (didn't test).
2019-09-03 14:02:12 +00:00
bool substitutesAllowed() const;
Move structured attrs handling into a separate class This is primarily because Derivation::{can,will}BuildLocally() depends on attributes like preferLocalBuild and requiredSystemFeatures, but it can't handle them properly because it doesn't have access to the structured attributes.
2018-09-28 12:31:16 +00:00
};
}
Copy permalink