lix/tests/flakes
John Ericson c11836126b Harden tests' bash
Use `set -u` and `set -o pipefail` to catch accidental mistakes and
failures more strongly.

 - `set -u` catches the use of undefined variables
 - `set -o pipefail` catches failures (like `set -e`) earlier in the
   pipeline.

This makes the tests a bit more robust. It is nice to read code not
worrying about these spurious success paths (via uncaught) errors
undermining the tests. Indeed, I caught some bugs doing this.

There are a few tests where we run a command that should fail, and then
search its output to make sure the failure message is one that we
expect. Before, since the `grep` was the last command in the pipeline
the exit code of those failing programs was silently ignored. Now with
`set -o pipefail` it won't be, and we have to do something so the
expected failure doesn't accidentally fail the test.

To do that we use `expect` and a new `expectStderr` to check for the
exact failing exit code. See the comments on each for why.

`grep -q` is replaced with `grepQuiet`, see the comments on that
function for why.

`grep -v` when we just want the exit code is replaced with `grepInverse,
see the comments on that function for why.

`grep -q -v` together is, surprise surprise, replaced with
`grepQuietInverse`, which is both combined.

Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
2023-03-08 10:26:30 -05:00
..
absolute-paths.sh Trivial changes from the lazy-trees branch 2022-12-07 14:06:34 +01:00
build-paths.sh Harden tests' bash 2023-03-08 10:26:30 -05:00
bundle.sh Move the 'nix bundle' tests 2022-07-13 20:49:07 +02:00
check.sh Harden tests' bash 2023-03-08 10:26:30 -05:00
circular.sh Split off the circular flake import tests 2022-07-13 20:37:32 +02:00
common.sh Harden tests' bash 2023-03-08 10:26:30 -05:00
config.sh Move flake-local-settings.sh 2022-07-13 20:51:28 +02:00
flakes.sh Harden tests' bash 2023-03-08 10:26:30 -05:00
follow-paths.sh Harden tests' bash 2023-03-08 10:26:30 -05:00
init.sh Fix the flakes init test 2023-01-30 11:21:52 +01:00
inputs.sh flakes: Differentiate self.outPath and self.sourceInfo.outPath 2023-02-22 03:31:24 +01:00
mercurial.sh Split off the Mercurial flake tests 2022-07-13 15:06:57 +02:00
run.sh
search-root.sh Move flake-searching.sh and make it less dependent on git 2022-07-13 20:55:17 +02:00
show.sh nix flake show: Ignore empty attrsets 2023-01-31 18:20:26 +01:00
unlocked-override.sh Trivial changes from the lazy-trees branch 2022-12-07 14:06:34 +01:00