Théophane Hufschmitt
f3f32f0c30
Merge pull request #5599 from fzakaria/faridzakaria/fix-progress-bar-leak
...
Fix heap use after free in progress-bar.cc
2021-12-01 16:28:38 +01:00
John Ericson
2f5c913d4a
Fix #5299
...
No matter what, we need to resize the buffer to not have any scratch
space after we do the `read`. In the end of file case, `got` will be 0
from it's initial value.
Before, we forgot to resize in the EOF case with the break. Yes, we know
we didn't recieve any data in that case, but we still have the scatch
space to undo.
Co-Authored-By: Will Fancher <Will.Fancher@Obsidian.Systems>
2021-11-30 22:11:46 +00:00
John Ericson
95157b4e66
Push wopAddToStore old style stream adapters into smaller scopes
...
This doesn't fix the bug, but makes the code less difficult to read.
Also improve the comments, now that it is clear what part is needed in
each code path.
2021-11-30 22:10:58 +00:00
John Ericson
70a717f7a8
Nix daemon stream old wopAddToStore
...
No more buffering in string.
2021-11-30 21:55:53 +00:00
John Ericson
1f15441103
Tidy up the logging
...
Use the macros more, so we properly skip work when the log level
excludes. Also log the daemon operation number on the daemon side.
2021-11-30 20:23:13 +00:00
Eelco Dolstra
1a9bfdc4ca
Merge pull request #5690 from efx/document-jargon
...
docs: document set theory symbols
2021-11-30 21:01:35 +01:00
Eelco Dolstra
d22ce8b68d
Merge pull request #5691 from NixOS/hydra-ci-test
...
Add a github cron to check the hydra status
2021-11-30 21:01:01 +01:00
Eli Flanagan
092c375cda
Update doc/manual/src/glossary.md
...
Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
2021-11-30 13:19:42 -05:00
regnat
5f64b69d23
Add a github cron to check the hydra status
...
Add a regular github action that will check the status of the latest
hydra evaluation.
Things aren’t ideal right now because this job will only notify “the
user who last modified the cron syntax in the workflow file” (so myself
atm). But at least that’ll give a notification for failing hydra jobs
2021-11-30 17:54:25 +01:00
Eli Flanagan
a473e85c80
docs: document set theory symbols
...
These symbols confused me so I wanted to gloss them to help future users. You can see the context here: https://discourse.nixos.org/t/flakes-what-does-mean-big-bundle-of-questions
2021-11-30 11:13:46 -05:00
Eelco Dolstra
b96164f4af
Merge remote-tracking branch 'origin/build-with-clang'
2021-11-30 11:50:56 +01:00
Yorick
bd628cf3da
flakes: fix boolean and int nixConfig values
...
Some type confusion was causing ints to be pointers, and bools
to be ints. Fixes #5621
2021-11-29 15:53:22 +01:00
Eelco Dolstra
92bcd77a67
Merge pull request #5683 from edolstra/nix-develop-cloexec
...
createTempFile(): Mark file as CLOEEXEC
2021-11-29 12:35:18 +01:00
Eelco Dolstra
6e0cbc666b
createTempFile(): Mark file as CLOEEXEC
...
Fixes #5674 .
2021-11-29 11:20:50 +01:00
Eelco Dolstra
e1420c66a4
Merge pull request #5680 from andir/libexpr-dont-move-primop-args
...
Don't move the arguments of the primOp
2021-11-29 11:11:54 +01:00
Eelco Dolstra
ddf4fb750d
Merge pull request #5678 from t184256/document-libsodium
...
Document libsodium, which is now mandatory, as a dependency.
2021-11-29 11:11:10 +01:00
Eelco Dolstra
99804465af
Merge pull request #5679 from t184256/optional-libcpuid
...
Document libcpuid dependency and make it optional
2021-11-29 11:10:42 +01:00
Eelco Dolstra
3d36f48acb
Merge pull request #5667 from NixOS/5661-dont-complete-flakes-without-xp-feature
...
Don’t try to complete flakes is the feature isn’t enabled
2021-11-29 10:51:41 +01:00
Eelco Dolstra
5c9a1ef30c
Merge pull request #5668 from tomberek/r13y_cores
...
reproducibility: determinstic man page output for cores
2021-11-29 10:51:02 +01:00
Eelco Dolstra
45abf0fa5f
Merge pull request #5677 from matklad/patch-2
...
Fix typo
2021-11-29 10:48:50 +01:00
Andreas Rammhold
90d8178009
Don't move the arguments of the primOp
...
Moving arguments of the primOp into the registration structure makes it
impossible to initialize a second EvalState with the correct primOp
registration. It will end up registering all those "RegisterPrimOp"'s
with an arity of zero on all but the 2nd instance of the EvalState.
Not moving the memory will add a tiny bit of memory overhead during the
eval since we need a copy of all the argument lists of all the primOp's.
The overhead shouldn't be too bad as it is static (based on the amonut
of registered operations) and only occurs once during the interpreter
startup.
2021-11-28 02:06:47 +01:00
Alexander Sosedkin
a9bd06d0ea
Make libcpuid dependency optional with --disable-cpuid
2021-11-28 00:52:35 +01:00
Alexander Sosedkin
b73a1c0638
Document libcpuid dependency
2021-11-28 00:52:35 +01:00
Alexander Sosedkin
33a227503a
Document libsodium, which is now mandatory, as a dependency
2021-11-27 23:11:11 +01:00
Alex Kladov
1d5a881da5
Fix typo
2021-11-27 23:29:48 +03:00
regnat
3a0277305a
Don’t try to complete flakes is the feature isn’t enabled
...
Fix #5661
2021-11-26 16:56:51 +01:00
Tom Bereknyei
152e3cda0c
reproducibility: determinstic man page output for cores
2021-11-26 10:55:43 -05:00
Eelco Dolstra
55275fcc59
Merge pull request #5665 from edolstra/repl-reset-terminal
...
nix repl: Reset the terminal on exceptional exits
2021-11-26 14:21:04 +01:00
Eelco Dolstra
3ef66cd23a
nix repl: Reset the terminal on exceptional exits
2021-11-26 13:10:28 +01:00
Eelco Dolstra
b653fb9ccf
Merge pull request #5662 from NixOS/5259-nix-shell-with-ca-bash
...
Make `nix-shell` work when nixpkgs is content-addressed
2021-11-26 12:47:30 +01:00
Eelco Dolstra
c18238d92a
Merge pull request #5664 from tweag/catch-exception-in-repl
...
Catch flake-related exception type in REPL
2021-11-26 12:46:59 +01:00
Alex Shabalin
6d166d19a6
Catch flake-related exception type in REPL
...
Closes https://github.com/NixOS/nix/issues/5656
2021-11-26 11:03:48 +01:00
Pamplemousse
288c252570
Documentation: alternative stdenv
for hacking
...
Signed-off-by: Pamplemousse <xav.maso@gmail.com>
2021-11-26 10:04:56 +01:00
regnat
e588f4c655
Add a matrix of stdenvs to the flake
...
For a (currently hardcoded and limited) list of stdenvs,
make `.#$nix-${stdenvName}` correspond to a Nix built with the
corresponding stdenv.
For example, `.#nix-${clang11Stdenv}` is Nix built with clang11.
Likewise, `devShells.x86_64-linux.clang11StdenvPackages` is a development
shell for Nix with clang11, that can be used with
```shell
nix develop .#clang11StdenvPackages
```
Fix #4129
/cc @pamplemousse
2021-11-26 10:04:13 +01:00
regnat
05081bedc1
Make nix-shell
work when nixpkgs is content-addressed
...
Fix #5259
2021-11-26 09:56:48 +01:00
Eelco Dolstra
5fcf7f04a9
Merge pull request #5384 from baloo/baloo/dns-timeout
...
preloadNSS / dns timeout
2021-11-25 17:37:53 +01:00
Eelco Dolstra
d5d0621250
Merge pull request #5603 from obsidiansystems/recursive-nix-system-feature
...
"recursive-nix" system feature only with experimental feature
2021-11-25 17:20:58 +01:00
Eelco Dolstra
6f46434f32
Merge pull request #5648 from edolstra/list-iter
...
Support range-based for loop over list values
2021-11-25 17:13:25 +01:00
Eelco Dolstra
986906e687
Update names
2021-11-25 17:09:11 +01:00
Eelco Dolstra
1d2dbbb977
Merge pull request #5654 from NixOS/pure-file-access-error-message
...
Fix the error when accessing a forbidden path in pure eval
2021-11-25 16:51:26 +01:00
Eelco Dolstra
b6c8e57056
Support range-based for loop over list values
2021-11-25 16:31:39 +01:00
Eelco Dolstra
ca82967ee3
Merge pull request #5653 from edolstra/fix-flake-checks
...
flake.nix: Only have checks.*.dockerImage on supported systems
2021-11-25 15:59:42 +01:00
regnat
c47027f3a1
Fix the error when accessing a forbidden path in pure eval
...
If we’re in pure eval mode, then tell that in the error message rather
than (wrongly) speaking about restricted mode.
Fix https://github.com/NixOS/nix/issues/5611
2021-11-25 14:48:01 +01:00
Eelco Dolstra
329b18711e
flake.nix: Only have checks.*.dockerImage on supported systems
2021-11-25 14:45:47 +01:00
Eelco Dolstra
1f7584d24c
Merge pull request #5644 from tweag/fix-interrupted-data-race
...
Fix a minor data race with _isInterrupted
2021-11-25 13:55:03 +01:00
Eelco Dolstra
d58f149140
Merge pull request #5631 from Infinisil/list-compare
...
Make lists be comparable
2021-11-24 15:48:05 +01:00
Alex Shabalin
2970ca18bf
Fix a minor data race with _isInterrupted
2021-11-24 14:50:08 +01:00
Eelco Dolstra
884674a8e2
nix flake check: Fix markdown
2021-11-24 13:53:09 +01:00
Silvan Mosberger
09471d2680
Make lists be comparable
...
Makes lists comparable using lexicographic comparison.
Increments builtins.langVersion in order for this change to be
detectable
2021-11-24 13:40:46 +01:00
Eelco Dolstra
6f4d1af971
Merge pull request #5636 from tweag/fix-use-after-free
...
Fix use after free in content-address.cc
2021-11-24 12:11:00 +01:00