From bfe1308d3ff7f3dfd4facf4318adcb459e57ece9 Mon Sep 17 00:00:00 2001
From: John Ericson <John.Ericson@Obsidian.Systems>
Date: Thu, 28 Sep 2023 21:21:58 -0400
Subject: [PATCH] Add infra for `InputSchemes` to be experimental

---
 src/libfetchers/fetchers.cc | 7 +++++++
 src/libfetchers/fetchers.hh | 5 +++++
 src/libutil/args.hh         | 2 +-
 3 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/src/libfetchers/fetchers.cc b/src/libfetchers/fetchers.cc
index 7bffb04ff..e3d3ac562 100644
--- a/src/libfetchers/fetchers.cc
+++ b/src/libfetchers/fetchers.cc
@@ -36,6 +36,7 @@ Input Input::fromURL(const ParsedURL & url, bool requireTree)
     for (auto & inputScheme : *inputSchemes) {
         auto res = inputScheme->inputFromURL(url, requireTree);
         if (res) {
+            experimentalFeatureSettings.require(inputScheme->experimentalFeature());
             res->scheme = inputScheme;
             fixupInput(*res);
             return std::move(*res);
@@ -50,6 +51,7 @@ Input Input::fromAttrs(Attrs && attrs)
     for (auto & inputScheme : *inputSchemes) {
         auto res = inputScheme->inputFromAttrs(attrs);
         if (res) {
+            experimentalFeatureSettings.require(inputScheme->experimentalFeature());
             res->scheme = inputScheme;
             fixupInput(*res);
             return std::move(*res);
@@ -309,4 +311,9 @@ void InputScheme::clone(const Input & input, const Path & destDir) const
     throw Error("do not know how to clone input '%s'", input.to_string());
 }
 
+std::optional<ExperimentalFeature> InputScheme::experimentalFeature()
+{
+    return {};
+}
+
 }
diff --git a/src/libfetchers/fetchers.hh b/src/libfetchers/fetchers.hh
index b27ac4128..b55aabb6f 100644
--- a/src/libfetchers/fetchers.hh
+++ b/src/libfetchers/fetchers.hh
@@ -158,6 +158,11 @@ struct InputScheme
     virtual void markChangedFile(const Input & input, std::string_view file, std::optional<std::string> commitMsg);
 
     virtual std::pair<StorePath, Input> fetch(ref<Store> store, const Input & input) = 0;
+
+    /**
+     * Is this `InputScheme` part of an experimental feature?
+     */
+    virtual std::optional<ExperimentalFeature> experimentalFeature();
 };
 
 void registerInputScheme(std::shared_ptr<InputScheme> && fetcher);
diff --git a/src/libutil/args.hh b/src/libutil/args.hh
index d90129796..1e5bac650 100644
--- a/src/libutil/args.hh
+++ b/src/libutil/args.hh
@@ -236,7 +236,7 @@ struct Command : virtual public Args
 
     static constexpr Category catDefault = 0;
 
-    virtual std::optional<ExperimentalFeature> experimentalFeature ();
+    virtual std::optional<ExperimentalFeature> experimentalFeature();
 
     virtual Category category() { return catDefault; }
 };