puck/lix
0
0
Fork 0
forked from lix-project/lix
Code Pull requests Activity

Improve ACL clearing support (fixing FreeBSD build)

Browse source 
The problem was that f880469173 forgot
that the `#include <sys/xattr.h>` was guarded by an `#ifdef __linux__`.

However, the build failure was only on FreeBSD --- turns out other
platforms have this header too!

The fix therefore uses a new configure check so we properly clear ACLs
on more platforms.
This commit is contained in:
John Ericson 2023-11-29 21:03:56 -05:00
parent a8fea5a54f
commit a7115a47ef
3 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
configure.ac
View file

@ -282,6 +282,8 @@ case "$host_os" in
esac esac
AC_SUBST(HAVE_SECCOMP, [$have_seccomp]) AC_SUBST(HAVE_SECCOMP, [$have_seccomp])
# Optional dependencies for better normalizing file system data
AC_CHECK_HEADERS[sys/xattr.h]
# Look for aws-cpp-sdk-s3. # Look for aws-cpp-sdk-s3.
AC_LANG_PUSH(C++) AC_LANG_PUSH(C++)

1
src/libstore/local-store.cc
View file

@ -34,7 +34,6 @@
#include <sys/statvfs.h> #include <sys/statvfs.h>
#include <sys/mount.h> #include <sys/mount.h>
#include <sys/ioctl.h> #include <sys/ioctl.h>
#include <sys/xattr.h>
#endif #endif
#ifdef __CYGWIN__ #ifdef __CYGWIN__

6
src/libstore/posix-fs-canonicalise.cc
View file

@ -1,4 +1,6 @@
#include <sys/xattr.h> #if HAVE_SYS_XATTR_H
# include <sys/xattr.h>
#endif
#include "posix-fs-canonicalise.hh" #include "posix-fs-canonicalise.hh"
#include "file-system.hh" #include "file-system.hh"
@ -76,7 +78,7 @@ static void canonicalisePathMetaData_(
if (!(S_ISREG(st.st_mode) || S_ISDIR(st.st_mode) || S_ISLNK(st.st_mode))) if (!(S_ISREG(st.st_mode) || S_ISDIR(st.st_mode) || S_ISLNK(st.st_mode)))
throw Error("file '%1%' has an unsupported type", path); throw Error("file '%1%' has an unsupported type", path);
#if __linux__ #ifdef HAVE_SYS_XATTR_H
/* Remove extended attributes / ACLs. */ /* Remove extended attributes / ACLs. */
ssize_t eaSize = llistxattr(path.c_str(), nullptr, 0); ssize_t eaSize = llistxattr(path.c_str(), nullptr, 0);