forked from lix-project/lix
Merge pull request #7307 from hercules-ci/derivation-goal-improve-comment
libstore/derivation-goal: Elaborate a TODO for performance concern
This commit is contained in:
commit
8d88c3b347
|
@ -544,7 +544,8 @@ void DerivationGoal::inputsRealised()
|
||||||
However, the impure derivations feature still relies on this
|
However, the impure derivations feature still relies on this
|
||||||
fragile way of doing things, because its builds do not have
|
fragile way of doing things, because its builds do not have
|
||||||
a representation in the store, which is a usability problem
|
a representation in the store, which is a usability problem
|
||||||
in itself */
|
in itself. When implementing this logic entirely with lookups
|
||||||
|
make sure that they're cached. */
|
||||||
if (auto outPath = get(inputDrvOutputs, { depDrvPath, j })) {
|
if (auto outPath = get(inputDrvOutputs, { depDrvPath, j })) {
|
||||||
worker.store.computeFSClosure(*outPath, inputPaths);
|
worker.store.computeFSClosure(*outPath, inputPaths);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in a new issue