puck/lix
0
0
Fork 0
forked from lix-project/lix
Code Pull requests Activity

* Reject patches that are larger than a certain fraction of the full archive

Browse source 
(currently 60%).  Large patches aren't very economical.
This commit is contained in:
Eelco Dolstra 2007-01-08 15:32:15 +00:00
parent 50bdec410a
commit 1f3722bd4a
1 changed files with 13 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
scripts/generate-patches.pl.in
View file

@ -4,6 +4,12 @@ use strict;
use File::Temp qw(tempdir); use File::Temp qw(tempdir);
use readmanifest; use readmanifest;
# Some hard-coded options.
my $maxNarSize = 100 * 1024 * 1024; # max size of NAR archives to generate patches for
my $maxPatchFraction = 0.60; # if patch is bigger than this fraction of full archive, reject
die unless scalar @ARGV == 5; die unless scalar @ARGV == 5;
my $hashAlgo = "sha256"; my $hashAlgo = "sha256";
@ -277,8 +283,6 @@ foreach my $p (keys %dstOutPaths) {
my $srcNarBz2 = getNarBz2 \%srcNarFiles, $closest; my $srcNarBz2 = getNarBz2 \%srcNarFiles, $closest;
my $dstNarBz2 = getNarBz2 \%dstNarFiles, $p; my $dstNarBz2 = getNarBz2 \%dstNarFiles, $p;
my $maxNarSize = 100 * 1024 * 1024;
system("@bunzip2@ < $srcNarBz2 > $tmpDir/A") == 0 system("@bunzip2@ < $srcNarBz2 > $tmpDir/A") == 0
or die "cannot unpack $srcNarBz2"; or die "cannot unpack $srcNarBz2";
@ -310,16 +314,21 @@ foreach my $p (keys %dstOutPaths) {
my $narDiffSize = (stat "$tmpDir/DIFF")[7]; my $narDiffSize = (stat "$tmpDir/DIFF")[7];
my $dstNarBz2Size = (stat $dstNarBz2)[7]; my $dstNarBz2Size = (stat $dstNarBz2)[7];
print " size $narDiffSize; full size $dstNarBz2Size\n";
if ($narDiffSize >= $dstNarBz2Size) { if ($narDiffSize >= $dstNarBz2Size) {
print " rejecting; patch bigger than full archive\n"; print " rejecting; patch bigger than full archive\n";
next; next;
} }
if ($narDiffSize / $dstNarBz2Size >= $maxPatchFraction) {
print " rejecting; patch too large relative to full archive\n";
next;
}
my $finalName = my $finalName =
"$narDiffHash.nar-bsdiff"; "$narDiffHash.nar-bsdiff";
print " size $narDiffSize; full size $dstNarBz2Size\n";
if (-e "$patchesDir/$finalName") { if (-e "$patchesDir/$finalName") {
print " not copying, already exists\n"; print " not copying, already exists\n";
} }