forked from lix-project/lix
5a34a473dd
This closes #3026 by allowing `builtins.readFile` to read a file with a wrongly reported file size, for example, files in `/proc` may report a file size of 0. Reading file in `/proc` is not a good enough motivation, however I do think it just makes nix more robust by allowing more file to be read. Especially, I do considerer the previous behavior to be dangerous because nix was previously reading truncated files. Examples of file system which incorrectly report file size may be network file system or dynamic file system (for performance reason, a dynamic file system such as FUSE may generate the content of the file on demand). ``` nix-repl> builtins.readFile "/proc/version" "" ``` With this commit: ``` nix-repl> builtins.readFile "/proc/version" "Linux version 5.6.7 (nixbld@localhost) (gcc version 9.3.0 (GCC)) #1-NixOS SMP Thu Apr 23 08:38:27 UTC 2020\n" ``` Here is a summary of the behavior changes: - If the reported size is smaller, previous implementation was silently returning a truncated file content. The new implementation is returning the correct file content. - If a file had a bigger reported file size, previous implementation was failing with an exception, but the new implementation is returning the correct file content. This change of behavior is coherent with this pull request. Open questions - The behavior is unchanged for correctly reported file size, however performances may vary because it uses the more complex sink interface. Considering that sink is used a lot, I don't think this impacts the performance a lot. - `builtins.readFile` on an infinite file, such as `/dev/random` may fill the memory. - it does not support adding file to store, such as `${/proc/version}`. |
||
|---|---|---|
| .. | ||
| affinity.cc | ||
| affinity.hh | ||
| ansicolor.hh | ||
| archive.cc | ||
| archive.hh | ||
| args.cc | ||
| args.hh | ||
| compression.cc | ||
| compression.hh | ||
| config.cc | ||
| config.hh | ||
| error.cc | ||
| error.hh | ||
| finally.hh | ||
| hash.cc | ||
| hash.hh | ||
| istringstream_nocopy.hh | ||
| json.cc | ||
| json.hh | ||
| lazy.hh | ||
| local.mk | ||
| logging.cc | ||
| logging.hh | ||
| lru-cache.hh | ||
| monitor-fd.hh | ||
| pool.hh | ||
| ref.hh | ||
| rust-ffi.cc | ||
| rust-ffi.hh | ||
| serialise.cc | ||
| serialise.hh | ||
| sync.hh | ||
| tarfile.cc | ||
| tarfile.hh | ||
| thread-pool.cc | ||
| thread-pool.hh | ||
| types.hh | ||
| url.cc | ||
| url.hh | ||
| util.cc | ||
| util.hh | ||
| xml-writer.cc | ||
| xml-writer.hh | ||