philiptaron/lix
0
0
Fork 0
forked from lix-project/lix
Code Pull requests Activity

feat(libstore): print the first line of stdout of SSH in case of failure

Browse source 
In case of failure to connect as can be seen in
https://buildbot.lix.systems/#/builders/39/builds/1386/steps/1/logs/stdio

It is difficult to understand what happened, if we enabled the talkative
verbose level, we could learn about the first line SSH sent us.

In practice, this is not workable, we can just make it warn all the
time.

Change-Id: Iaaf56894060a58f2dfc78254bb60b1c43482f9bb
Signed-off-by: Raito Bezarius <raito@lix.systems>
This commit is contained in:
raito 2024-05-10 19:54:42 +02:00
parent 964ac8b0e8
commit 8404a1f66d
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/libstore/ssh.cc
View file

@ -110,7 +110,7 @@ std::unique_ptr<SSHMaster::Connection> SSHMaster::startCommand(const std::string
} catch (EndOfFile & e) { } } catch (EndOfFile & e) { }
if (reply != "started") { if (reply != "started") {
printTalkative("SSH stdout first line: %s", reply); warn("SSH to '%s' failed, stdout first line: '%s'", host, reply);
throw Error("failed to start SSH connection to '%s'", host); throw Error("failed to start SSH connection to '%s'", host);
} }
} }