philiptaron/lix
0
0
Fork 0
forked from lix-project/lix
Code Pull requests Activity
lix/src/libstore/dummy-store.cc

64 lines
1.7 KiB
C++
Raw Normal View History

Add DummyStore (dummy://) DummyStore does not allow building or adding paths. This is useful for evaluation tests when you don't want to initialize a "proper" store.
2020-08-24 16:54:16 +00:00
#include "store-api.hh"
Move Callback into its own header This gets rid of the inclusion of <future> in util.hh, cutting compilation time by ~20s (CPU time). Issue #4045.
2020-09-21 16:40:11 +00:00
#include "callback.hh"
Add DummyStore (dummy://) DummyStore does not allow building or adding paths. This is useful for evaluation tests when you don't want to initialize a "proper" store.
2020-08-24 16:54:16 +00:00
namespace nix {
Document the new store hierarchy
2020-09-14 09:18:45 +00:00
struct DummyStoreConfig : virtual StoreConfig {
Correctly call all the parent contructors of the stores Using virtual inheritance means that only the default constructors of the parent classes will be called, which isn't what we want
2020-09-11 09:06:18 +00:00
using StoreConfig::StoreConfig;
Add a name to the stores So that it can be printed by `nix describe-stores`
2020-09-14 12:04:02 +00:00
const std::string name() override { return "Dummy Store"; }
Correctly call all the parent contructors of the stores Using virtual inheritance means that only the default constructors of the parent classes will be called, which isn't what we want
2020-09-11 09:06:18 +00:00
};
Separate store configs from the implems Rework the `Store` hierarchy so that there's now one hierarchy for the store configs and one for the implementations (where each implementation extends the corresponding config). So a class hierarchy like ``` StoreConfig-------->Store | | v v SubStoreConfig----->SubStore | | v v SubSubStoreConfig-->SubSubStore ``` (with virtual inheritance to prevent DDD). The advantage of this architecture is that we can now introspect the configuration of a store without having to instantiate the store itself
2020-09-10 08:55:51 +00:00
Overhaul store subclassing We embrace virtual the rest of the way, and get rid of the `assert(false)` 0-param constructors. We also list config base classes first, so the constructor order is always: 1. all the configs 2. all the stores Each in the same order
2020-12-20 15:33:12 +00:00
struct DummyStore : public virtual DummyStoreConfig, public virtual Store
Add DummyStore (dummy://) DummyStore does not allow building or adding paths. This is useful for evaluation tests when you don't want to initialize a "proper" store.
2020-08-24 16:54:16 +00:00
{
Properly filter the stores according to their declared uriSchemes When opening a store, only try the stores whose `uriSchemes()` include the current one
2020-09-11 09:11:05 +00:00
DummyStore(const std::string scheme, const std::string uri, const Params & params)
Separate the instantiation and initialisation of the stores Add a new `init()` method to the `Store` class that is supposed to handle all the effectful initialisation needed to set-up the store. The constructor should remain side-effect free and just initialize the c++ data structure. The goal behind that is that we can create “dummy” instances of each store to query static properties about it (the parameters it accepts for example)
2020-09-09 09:29:17 +00:00
: DummyStore(params)
{ }
DummyStore(const Params & params)
Correctly call all the parent contructors of the stores Using virtual inheritance means that only the default constructors of the parent classes will be called, which isn't what we want
2020-09-11 09:06:18 +00:00
: StoreConfig(params)
Overhaul store subclassing We embrace virtual the rest of the way, and get rid of the `assert(false)` 0-param constructors. We also list config base classes first, so the constructor order is always: 1. all the configs 2. all the stores Each in the same order
2020-12-20 15:33:12 +00:00
, DummyStoreConfig(params)
Correctly call all the parent contructors of the stores Using virtual inheritance means that only the default constructors of the parent classes will be called, which isn't what we want
2020-09-11 09:06:18 +00:00
, Store(params)
Shut up some clang warnings
2020-10-06 12:00:42 +00:00
{ }
Add DummyStore (dummy://) DummyStore does not allow building or adding paths. This is useful for evaluation tests when you don't want to initialize a "proper" store.
2020-08-24 16:54:16 +00:00
Remove std::string alias (for real this time) Also use std::string_view in a few more places.
2022-02-25 15:00:00 +00:00
std::string getUri() override
Add DummyStore (dummy://) DummyStore does not allow building or adding paths. This is useful for evaluation tests when you don't want to initialize a "proper" store.
2020-08-24 16:54:16 +00:00
{
Properly filter the stores according to their declared uriSchemes When opening a store, only try the stores whose `uriSchemes()` include the current one
2020-09-11 09:11:05 +00:00
return *uriSchemes().begin();
Add DummyStore (dummy://) DummyStore does not allow building or adding paths. This is useful for evaluation tests when you don't want to initialize a "proper" store.
2020-08-24 16:54:16 +00:00
}
void queryPathInfoUncached(const StorePath & path,
Callback<std::shared_ptr<const ValidPathInfo>> callback) noexcept override
{
callback(nullptr);
}
Properly filter the stores according to their declared uriSchemes When opening a store, only try the stores whose `uriSchemes()` include the current one
2020-09-11 09:11:05 +00:00
static std::set<std::string> uriSchemes() {
Make the store plugins more introspectable Directly register the store classes rather than a function to build an instance of them. This gives the possibility to introspect static members of the class or choose different ways of instantiating them.
2020-09-08 12:50:23 +00:00
return {"dummy"};
}
Add DummyStore (dummy://) DummyStore does not allow building or adding paths. This is useful for evaluation tests when you don't want to initialize a "proper" store.
2020-08-24 16:54:16 +00:00
std::optional<StorePath> queryPathFromHashPart(const std::string & hashPart) override
{ unsupported("queryPathFromHashPart"); }
void addToStore(const ValidPathInfo & info, Source & source,
RepairFlag repair, CheckSigsFlag checkSigs) override
{ unsupported("addToStore"); }
Remove std::string alias (for real this time) Also use std::string_view in a few more places.
2022-02-25 15:00:00 +00:00
StorePath addTextToStore(
std::string_view name,
std::string_view s,
const StorePathSet & references,
RepairFlag repair) override
Add DummyStore (dummy://) DummyStore does not allow building or adding paths. This is useful for evaluation tests when you don't want to initialize a "proper" store.
2020-08-24 16:54:16 +00:00
{ unsupported("addTextToStore"); }
void narFromPath(const StorePath & path, Sink & sink) override
{ unsupported("narFromPath"); }
Expose an async interface for `queryRealisation` Doesn’t change much so far because everything is still using it synchronously, but should allow the binary cache to fetch stuff in parallel
2021-10-27 09:36:51 +00:00
void queryRealisationUncached(const DrvOutput &,
Callback<std::shared_ptr<const Realisation>> callback) noexcept override
{ callback(nullptr); }
Add DummyStore (dummy://) DummyStore does not allow building or adding paths. This is useful for evaluation tests when you don't want to initialize a "proper" store.
2020-08-24 16:54:16 +00:00
};
Remove static variable name clashes This was useful for an experiment with building Nix as a single compilation unit. It's not very useful otherwise but also doesn't hurt...
2020-10-06 11:36:55 +00:00
static RegisterStoreImplementation<DummyStore, DummyStoreConfig> regDummyStore;
Add DummyStore (dummy://) DummyStore does not allow building or adding paths. This is useful for evaluation tests when you don't want to initialize a "proper" store.
2020-08-24 16:54:16 +00:00
}
Copy permalink