A modern, delicious implementation of the Nix package manager, focused on correctness, usability, and growth — and committed to doing right by its community

Find a file

jade c897fba787 store: fix null reference from DerivationGoal::waiteeDone This happened during a PathSubstitutionGoal of a .drv file: substitution of '/tmp/jade/nix-test/ca/eval-store/store/1lj7lsq5y0f25mfbnq6d3zd0bw5ay33n-dependencies-input-2.drv' What happened here is that since PathSubstitutionGoal is not a DerivationGoal, in production builds, the UB was not caught, since it would early-exit from failing a dynamic_cast to DerivationGoal * on the very next line, but before the null reference was ever used. This was nonetheless UB. The fix should be to just rearrange the two lines; I don't think there is a further bug there, since substituting a .drv necessarily means you cannot have the representation of the derivation as would be necessary for drv to not be null there. Test failure: ++(eval-store.sh:12) _RR_TRACE_DIR=/home/jade/.local/share/rr rr record -- nix build -f dependencies.nix --eval-store /tmp/jade/nix-test/ca/eval-store/eval-store -o /tmp/jade/nix-test/ca/eval-store/result don't know how to build these paths: /tmp/jade/nix-test/ca/eval-store/store/6y51mf0p57ggipgab6hdjabbvplzsicq-dependencies-top.drv copying 1 paths... copying path '/tmp/jade/nix-test/ca/eval-store/store/8027afyvqb87y1sf5xhdkqsflqn1ziy8-dependencies.builder0.sh' to 'local'... copying 1 paths... copying path '/tmp/jade/nix-test/ca/eval-store/store/7r5pqyncvfgrryf9gzy1z56z3xigi61x-builder-dependencies-input-0.sh' to 'local'... copying 1 paths... copying path '/tmp/jade/nix-test/ca/eval-store/store/nhmgm87zlqy3ks96dxrn7l37b72azi99-builder-dependencies-input-1.sh' to 'local'... copying 1 paths... copying path '/tmp/jade/nix-test/ca/eval-store/store/nq4qa2j6y8ajqazlfq6h46ck637my1n6-builder-dependencies-input-2.sh' to 'local'... copying 1 paths... copying path '/tmp/jade/nix-test/ca/eval-store/store/6vh0vna9l5afck01y7iaks3hm9ikwqyj-builder-fod-input.sh' to 'local'... building '/tmp/jade/nix-test/ca/eval-store/store/gy91pqymf2nc5v7ld1bad94xpwxdi25s-dependencies-input-0.drv'... building '/tmp/jade/nix-test/ca/eval-store/store/w7wlkjx97ivmnrymkac5av3nyp94hzvq-dependencies-input-1.drv'... ../src/libstore/build/derivation-goal.cc:1556:22: runtime error: reference binding to null pointer of type 'Derivation' 0 0x734ba59a6886 in nix::DerivationGoal::waiteeDone(std::shared_ptr<nix::Goal>, nix::Goal::ExitCode) /home/jade/lix/lix2/build/src/libstore/build/derivation-goal.cc:1556:12 1 0x734ba59c0962 in nix::Goal::amDone(nix::Goal::ExitCode, std::optional<nix::Error>) /home/jade/lix/lix2/build/src/libstore/build/goal.cc:95:25 2 0x734ba5a1c44a in nix::PathSubstitutionGoal::done(nix::Goal::ExitCode, nix::BuildResult::Status, std::optional<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>>) /home/jade/lix/lix2/build/src/libstore/build/substitution-goal.cc:38:5 3 0x734ba5a1b454 in nix::PathSubstitutionGoal::init() /home/jade/lix/lix2/build/src/libstore/build/substitution-goal.cc:56:9 4 0x734ba5a2a6c6 in nix::Worker::run(std::set<std::shared_ptr<nix::Goal>, nix::CompareGoalPtrs, std::allocator<std::shared_ptr<nix::Goal>>> const&) /home/jade/lix/lix2/build/src/libstore/build/worker.cc:320:23 5 0x734ba59b93d8 in nix::Store::buildPathsWithResults(std::vector<nix::DerivedPath, std::allocator<nix::DerivedPath>> const&, nix::BuildMode, std::shared_ptr<nix::Store>) /home/jade/lix/lix2/build/src/libstore/build/entry-points.cc:60:12 6 0x734ba663c107 in nix::Installable::build2(nix::ref<nix::Store>, nix::ref<nix::Store>, nix::Realise, std::vector<nix::ref<nix::Installable>, std::allocator<nix::ref<nix::Installable>>> const&, nix::BuildMode) /home/jade/lix/lix2/build/src/libcmd/installables.cc:637:36 Change-Id: `Id0e651e480bebf6356733b01bc639e9bb59c7bd0`		2024-06-18 19:26:54 -07:00
.github	.github: clean up stale things and wrong references	2024-06-12 15:34:23 -07:00
bench	Add benchmarking scripts	2024-04-08 19:50:24 -07:00
clang-tidy	clang-tidy: work with angle brackets and external projects	2024-05-24 02:22:58 +00:00
contrib	function-trace: always show the trace	2019-09-18 23:23:21 +02:00
doc	repl: implement tab completing :colon commands	2024-06-17 13:08:02 +00:00
lix-doc	lix-doc: don't chomp bold headings off	2024-05-15 15:24:03 -07:00
maintainers	releng: automatically add to the summary page	2024-06-15 18:46:18 -07:00
meson	packaging: rename nixexpr -> lixexpr and so on	2024-05-23 16:45:23 -06:00
misc	Misc workaround removals since 24.05 upgrade	2024-06-12 15:34:23 -07:00
nix-support	Move version to a JSON file so we can have release names	2024-06-06 15:08:12 -07:00
perl	Move version to a JSON file so we can have release names	2024-06-06 15:08:12 -07:00
releng	releng: fix broken manifest from 2.90-rc1	2024-06-16 13:34:04 -07:00
scripts	remove the autoconf+Make buildsystem	2024-05-07 17:04:30 -06:00
src	store: fix null reference from DerivationGoal::waiteeDone	2024-06-18 19:26:54 -07:00
subprojects/aws_sdk	build: fix static aws-cpp-sdk	2024-05-30 00:40:25 -06:00
tests	filetransfer: {up,down}load -> transfer	2024-06-18 23:58:25 +00:00
.clang-format	Add `pre-commit` checks	2024-03-29 22:57:40 -07:00
.clang-tidy	Add basic clang-tidy config	2024-03-29 20:26:38 -07:00
.dir-locals.el	.dir-locals.el: Set c-block-comment-prefix	2020-07-10 11:21:06 +02:00
.editorconfig	add editorconfig for markdown	2024-05-24 02:22:44 +00:00
.envrc	Set `MAKEFLAGS=-j` and `GTEST_BRIEF` in `.envrc`	2024-03-28 18:17:28 -07:00
.gitignore	Put into place initial release engineering	2024-06-06 20:53:08 -07:00
boehmgc-coroutine-sp-fallback.diff	[resubmit] flake: update nixpkgs pin 23.11->24.05 (+ boehmgc compat changes)	2024-06-12 15:34:22 -07:00
CONTRIBUTING.md	chore: re-work the contribution guide	2024-05-07 01:28:35 +00:00
COPYING	Add `pre-commit` checks	2024-03-29 22:57:40 -07:00
default.nix	Format Nix code with `nixfmt`	2024-04-08 13:00:00 -07:00
docker.nix	releng: support multiarch docker images	2024-06-09 20:33:24 -07:00
flake.lock	[resubmit] flake: update nixpkgs pin 23.11->24.05 (+ boehmgc compat changes)	2024-06-12 15:34:22 -07:00
flake.nix	Merge pull request #10799 from hercules-ci/safer-tab-completion	2024-06-16 04:03:32 +00:00
justfile	justfile: remove --quiet from `just test`	2024-05-24 02:22:25 +00:00
meson.build	build: make UBSan work :)	2024-06-18 19:25:58 -07:00
meson.options	build: expose option to enable or disable precompiled std headers	2024-06-06 12:46:26 -06:00
package.nix	packaging: Move binaryTarball to a passthru attr in package.nix	2024-06-13 15:14:22 -07:00
README.md	chore: rebrand Nix to Lix when it makes sense	2024-06-01 20:31:24 +02:00
shell.nix	shell.nix: conform to documentation	2024-05-27 16:47:40 +02:00
treefmt.toml	Format Nix code with `nixfmt`	2024-04-08 13:00:00 -07:00
version.json	version: update to 2.91-dev for main	2024-06-15 18:46:18 -07:00

README.md

Lix

Lix is an implementation of Nix, a powerful package management system for Linux and other Unix systems that makes package management reliable and reproducible.

Read more about us at https://lix.systems.

Installation

On Linux and macOS the easiest way to install Lix is to run the following shell command (as a user other than root):

$ curl -sSf -L https://install.lix.systems/lix | sh -s -- install

For systems that already have a Nix implementation installed, such as NixOS systems, read our install page

Building And Developing

See our Hacking guide in our manual for instruction on how to to set up a development environment and build Lix from source.

Additional Resources

License

Lix is released under the LGPL v2.1.