forked from lix-project/lix
5576d5e987
Prior to this change, we had a bunch of ad-hoc string manipulation code scattered around. This made it hard to figure out what data model for string contexts is. Now, we still store string contexts most of the time as encoded strings --- I was wary of the performance implications of changing that --- but whenever we parse them we do so only through the `NixStringContextElem::parse` method, which handles all cases. This creates a data type that is very similar to `DerivedPath` but: - Represents the funky `=<drvpath>` case as properly distinct from the others. - Only encodes a single output, no wildcards and no set, for the "built" case. (I would like to deprecate `=<path>`, after which we are in spitting distance of `DerivedPath` and could maybe get away with fewer types, but that is another topic for another day.)
73 lines
2.2 KiB
C++
73 lines
2.2 KiB
C++
#include "value/context.hh"
|
|
|
|
#include "libexprtests.hh"
|
|
|
|
namespace nix {
|
|
|
|
// Testing of trivial expressions
|
|
struct NixStringContextElemTest : public LibExprTest {
|
|
const Store & store() const {
|
|
return *LibExprTest::store;
|
|
}
|
|
};
|
|
|
|
TEST_F(NixStringContextElemTest, empty_invalid) {
|
|
EXPECT_THROW(
|
|
NixStringContextElem::parse(store(), ""),
|
|
BadNixStringContextElem);
|
|
}
|
|
|
|
TEST_F(NixStringContextElemTest, single_bang_invalid) {
|
|
EXPECT_THROW(
|
|
NixStringContextElem::parse(store(), "!"),
|
|
BadNixStringContextElem);
|
|
}
|
|
|
|
TEST_F(NixStringContextElemTest, double_bang_invalid) {
|
|
EXPECT_THROW(
|
|
NixStringContextElem::parse(store(), "!!/"),
|
|
BadStorePath);
|
|
}
|
|
|
|
TEST_F(NixStringContextElemTest, eq_slash_invalid) {
|
|
EXPECT_THROW(
|
|
NixStringContextElem::parse(store(), "=/"),
|
|
BadStorePath);
|
|
}
|
|
|
|
TEST_F(NixStringContextElemTest, slash_invalid) {
|
|
EXPECT_THROW(
|
|
NixStringContextElem::parse(store(), "/"),
|
|
BadStorePath);
|
|
}
|
|
|
|
TEST_F(NixStringContextElemTest, opaque) {
|
|
std::string_view opaque = "/nix/store/g1w7hy3qg1w7hy3qg1w7hy3qg1w7hy3q-x";
|
|
auto elem = NixStringContextElem::parse(store(), opaque);
|
|
auto * p = std::get_if<NixStringContextElem::Opaque>(&elem);
|
|
ASSERT_TRUE(p);
|
|
ASSERT_EQ(p->path, store().parseStorePath(opaque));
|
|
ASSERT_EQ(elem.to_string(store()), opaque);
|
|
}
|
|
|
|
TEST_F(NixStringContextElemTest, drvDeep) {
|
|
std::string_view drvDeep = "=/nix/store/g1w7hy3qg1w7hy3qg1w7hy3qg1w7hy3q-x.drv";
|
|
auto elem = NixStringContextElem::parse(store(), drvDeep);
|
|
auto * p = std::get_if<NixStringContextElem::DrvDeep>(&elem);
|
|
ASSERT_TRUE(p);
|
|
ASSERT_EQ(p->drvPath, store().parseStorePath(drvDeep.substr(1)));
|
|
ASSERT_EQ(elem.to_string(store()), drvDeep);
|
|
}
|
|
|
|
TEST_F(NixStringContextElemTest, built) {
|
|
std::string_view built = "!foo!/nix/store/g1w7hy3qg1w7hy3qg1w7hy3qg1w7hy3q-x.drv";
|
|
auto elem = NixStringContextElem::parse(store(), built);
|
|
auto * p = std::get_if<NixStringContextElem::Built>(&elem);
|
|
ASSERT_TRUE(p);
|
|
ASSERT_EQ(p->output, "foo");
|
|
ASSERT_EQ(p->drvPath, store().parseStorePath(built.substr(5)));
|
|
ASSERT_EQ(elem.to_string(store()), built);
|
|
}
|
|
|
|
}
|