forked from lix-project/lix
![John Ericson](/assets/img/avatar_default.png)
We want to be able to write down `foo.drv^bar.drv^baz`: `foo.drv^bar.drv` is the dynamic derivation (since it is itself a derivation output, `bar.drv` from `foo.drv`). To that end, we create `Single{Derivation,BuiltPath}` types, that are very similar except instead of having multiple outputs (in a set or map), they have a single one. This is for everything to the left of the rightmost `^`. `NixStringContextElem` has an analogous change, and now can reuse `SingleDerivedPath` at the top level. In fact, if we ever get rid of `DrvDeep`, `NixStringContextElem` could be replaced with `SingleDerivedPath` entirely! Important note: some JSON formats have changed. We already can *produce* dynamic derivations, but we can't refer to them directly. Today, we can merely express building or example at the top imperatively over time by building `foo.drv^bar.drv`, and then with a second nix invocation doing `<result-from-first>^baz`, but this is not declarative. The ethos of Nix of being able to write down the full plan everything you want to do, and then execute than plan with a single command, and for that we need the new inductive form of these types. Co-authored-by: Robert Hensing <roberth@users.noreply.github.com> Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
150 lines
4.5 KiB
C++
150 lines
4.5 KiB
C++
#include <regex>
|
|
|
|
#include <nlohmann/json.hpp>
|
|
#include <gtest/gtest.h>
|
|
#include <rapidcheck/gtest.h>
|
|
|
|
#include "tests/derived-path.hh"
|
|
#include "tests/libstore.hh"
|
|
|
|
namespace rc {
|
|
using namespace nix;
|
|
|
|
Gen<DerivedPath::Opaque> Arbitrary<DerivedPath::Opaque>::arbitrary()
|
|
{
|
|
return gen::just(DerivedPath::Opaque {
|
|
.path = *gen::arbitrary<StorePath>(),
|
|
});
|
|
}
|
|
|
|
Gen<SingleDerivedPath::Built> Arbitrary<SingleDerivedPath::Built>::arbitrary()
|
|
{
|
|
return gen::just(SingleDerivedPath::Built {
|
|
.drvPath = make_ref<SingleDerivedPath>(*gen::arbitrary<SingleDerivedPath>()),
|
|
.output = (*gen::arbitrary<StorePathName>()).name,
|
|
});
|
|
}
|
|
|
|
Gen<DerivedPath::Built> Arbitrary<DerivedPath::Built>::arbitrary()
|
|
{
|
|
return gen::just(DerivedPath::Built {
|
|
.drvPath = make_ref<SingleDerivedPath>(*gen::arbitrary<SingleDerivedPath>()),
|
|
.outputs = *gen::arbitrary<OutputsSpec>(),
|
|
});
|
|
}
|
|
|
|
Gen<SingleDerivedPath> Arbitrary<SingleDerivedPath>::arbitrary()
|
|
{
|
|
switch (*gen::inRange<uint8_t>(0, std::variant_size_v<SingleDerivedPath::Raw>)) {
|
|
case 0:
|
|
return gen::just<SingleDerivedPath>(*gen::arbitrary<SingleDerivedPath::Opaque>());
|
|
case 1:
|
|
return gen::just<SingleDerivedPath>(*gen::arbitrary<SingleDerivedPath::Built>());
|
|
default:
|
|
assert(false);
|
|
}
|
|
}
|
|
|
|
Gen<DerivedPath> Arbitrary<DerivedPath>::arbitrary()
|
|
{
|
|
switch (*gen::inRange<uint8_t>(0, std::variant_size_v<DerivedPath::Raw>)) {
|
|
case 0:
|
|
return gen::just<DerivedPath>(*gen::arbitrary<DerivedPath::Opaque>());
|
|
case 1:
|
|
return gen::just<DerivedPath>(*gen::arbitrary<DerivedPath::Built>());
|
|
default:
|
|
assert(false);
|
|
}
|
|
}
|
|
|
|
}
|
|
|
|
namespace nix {
|
|
|
|
class DerivedPathTest : public LibStoreTest
|
|
{
|
|
};
|
|
|
|
/**
|
|
* Round trip (string <-> data structure) test for
|
|
* `DerivedPath::Opaque`.
|
|
*/
|
|
TEST_F(DerivedPathTest, opaque) {
|
|
std::string_view opaque = "/nix/store/g1w7hy3qg1w7hy3qg1w7hy3qg1w7hy3q-x";
|
|
auto elem = DerivedPath::parse(*store, opaque);
|
|
auto * p = std::get_if<DerivedPath::Opaque>(&elem);
|
|
ASSERT_TRUE(p);
|
|
ASSERT_EQ(p->path, store->parseStorePath(opaque));
|
|
ASSERT_EQ(elem.to_string(*store), opaque);
|
|
}
|
|
|
|
/**
|
|
* Round trip (string <-> data structure) test for a simpler
|
|
* `DerivedPath::Built`.
|
|
*/
|
|
TEST_F(DerivedPathTest, built_opaque) {
|
|
std::string_view built = "/nix/store/g1w7hy3qg1w7hy3qg1w7hy3qg1w7hy3q-x.drv^bar,foo";
|
|
auto elem = DerivedPath::parse(*store, built);
|
|
auto * p = std::get_if<DerivedPath::Built>(&elem);
|
|
ASSERT_TRUE(p);
|
|
ASSERT_EQ(p->outputs, ((OutputsSpec) OutputsSpec::Names { "foo", "bar" }));
|
|
ASSERT_EQ(*p->drvPath, ((SingleDerivedPath) SingleDerivedPath::Opaque {
|
|
.path = store->parseStorePath(built.substr(0, 49)),
|
|
}));
|
|
ASSERT_EQ(elem.to_string(*store), built);
|
|
}
|
|
|
|
/**
|
|
* Round trip (string <-> data structure) test for a more complex,
|
|
* inductive `DerivedPath::Built`.
|
|
*/
|
|
TEST_F(DerivedPathTest, built_built) {
|
|
/**
|
|
* We set these in tests rather than the regular globals so we don't have
|
|
* to worry about race conditions if the tests run concurrently.
|
|
*/
|
|
ExperimentalFeatureSettings mockXpSettings;
|
|
mockXpSettings.set("experimental-features", "dynamic-derivations ca-derivations");
|
|
|
|
std::string_view built = "/nix/store/g1w7hy3qg1w7hy3qg1w7hy3qg1w7hy3q-x.drv^foo^bar,baz";
|
|
auto elem = DerivedPath::parse(*store, built, mockXpSettings);
|
|
auto * p = std::get_if<DerivedPath::Built>(&elem);
|
|
ASSERT_TRUE(p);
|
|
ASSERT_EQ(p->outputs, ((OutputsSpec) OutputsSpec::Names { "bar", "baz" }));
|
|
auto * drvPath = std::get_if<SingleDerivedPath::Built>(&*p->drvPath);
|
|
ASSERT_TRUE(drvPath);
|
|
ASSERT_EQ(drvPath->output, "foo");
|
|
ASSERT_EQ(*drvPath->drvPath, ((SingleDerivedPath) SingleDerivedPath::Opaque {
|
|
.path = store->parseStorePath(built.substr(0, 49)),
|
|
}));
|
|
ASSERT_EQ(elem.to_string(*store), built);
|
|
}
|
|
|
|
/**
|
|
* Without the right experimental features enabled, we cannot parse a
|
|
* complex inductive derived path.
|
|
*/
|
|
TEST_F(DerivedPathTest, built_built_xp) {
|
|
ASSERT_THROW(
|
|
DerivedPath::parse(*store, "/nix/store/g1w7hy3qg1w7hy3qg1w7hy3qg1w7hy3q-x.drv^foo^bar,baz"),
|
|
MissingExperimentalFeature);
|
|
}
|
|
|
|
RC_GTEST_FIXTURE_PROP(
|
|
DerivedPathTest,
|
|
prop_legacy_round_rip,
|
|
(const DerivedPath & o))
|
|
{
|
|
RC_ASSERT(o == DerivedPath::parseLegacy(*store, o.to_string_legacy(*store)));
|
|
}
|
|
|
|
RC_GTEST_FIXTURE_PROP(
|
|
DerivedPathTest,
|
|
prop_round_rip,
|
|
(const DerivedPath & o))
|
|
{
|
|
RC_ASSERT(o == DerivedPath::parse(*store, o.to_string(*store)));
|
|
}
|
|
|
|
}
|