forked from lix-project/lix
8d4268d190
Changes: * The divider lines are gone. These were in practice a bit confusing, in particular with --show-trace or --keep-going, since then there were multiple lines, suggesting a start/end which wasn't the case. * Instead, multi-line error messages are now indented to align with the prefix (e.g. "error: "). * The 'description' field is gone since we weren't really using it. * 'hint' is renamed to 'msg' since it really wasn't a hint. * The error is now printed *before* the location info. * The 'name' field is no longer printed since most of the time it wasn't very useful since it was just the name of the exception (like EvalError). Ideally in the future this would be a unique, easily googleable error ID (like rustc). * "trace:" is now just "…". This assumes error contexts start with something like "while doing X". Example before: error: --- AssertionError ---------------------------------------------------------------------------------------- nix at: (7:7) in file: /home/eelco/Dev/nixpkgs/pkgs/applications/misc/hello/default.nix 6| 7| x = assert false; 1; | ^ 8| assertion 'false' failed ----------------------------------------------------- show-trace ----------------------------------------------------- trace: while evaluating the attribute 'x' of the derivation 'hello-2.10' at: (192:11) in file: /home/eelco/Dev/nixpkgs/pkgs/stdenv/generic/make-derivation.nix 191| // (lib.optionalAttrs (!(attrs ? name) && attrs ? pname && attrs ? version)) { 192| name = "${attrs.pname}-${attrs.version}"; | ^ 193| } // (lib.optionalAttrs (stdenv.hostPlatform != stdenv.buildPlatform && !dontAddHostSuffix && (attrs ? name || (attrs ? pname && attrs ? version)))) { Example after: error: assertion 'false' failed at: (7:7) in file: /home/eelco/Dev/nixpkgs/pkgs/applications/misc/hello/default.nix 6| 7| x = assert false; 1; | ^ 8| … while evaluating the attribute 'x' of the derivation 'hello-2.10' at: (192:11) in file: /home/eelco/Dev/nixpkgs/pkgs/stdenv/generic/make-derivation.nix 191| // (lib.optionalAttrs (!(attrs ? name) && attrs ? pname && attrs ? version)) { 192| name = "${attrs.pname}-${attrs.version}"; | ^ 193| } // (lib.optionalAttrs (stdenv.hostPlatform != stdenv.buildPlatform && !dontAddHostSuffix && (attrs ? name || (attrs ? pname && attrs ? version)))) {
194 lines
7 KiB
C++
194 lines
7 KiB
C++
#include "buildenv.hh"
|
|
|
|
#include <sys/stat.h>
|
|
#include <sys/types.h>
|
|
#include <fcntl.h>
|
|
#include <algorithm>
|
|
|
|
namespace nix {
|
|
|
|
struct State
|
|
{
|
|
std::map<Path, int> priorities;
|
|
unsigned long symlinks = 0;
|
|
};
|
|
|
|
/* For each activated package, create symlinks */
|
|
static void createLinks(State & state, const Path & srcDir, const Path & dstDir, int priority)
|
|
{
|
|
DirEntries srcFiles;
|
|
|
|
try {
|
|
srcFiles = readDirectory(srcDir);
|
|
} catch (SysError & e) {
|
|
if (e.errNo == ENOTDIR) {
|
|
warn("not including '%s' in the user environment because it's not a directory", srcDir);
|
|
return;
|
|
}
|
|
throw;
|
|
}
|
|
|
|
for (const auto & ent : srcFiles) {
|
|
if (ent.name[0] == '.')
|
|
/* not matched by glob */
|
|
continue;
|
|
auto srcFile = srcDir + "/" + ent.name;
|
|
auto dstFile = dstDir + "/" + ent.name;
|
|
|
|
struct stat srcSt;
|
|
try {
|
|
if (stat(srcFile.c_str(), &srcSt) == -1)
|
|
throw SysError("getting status of '%1%'", srcFile);
|
|
} catch (SysError & e) {
|
|
if (e.errNo == ENOENT || e.errNo == ENOTDIR) {
|
|
warn("skipping dangling symlink '%s'", dstFile);
|
|
continue;
|
|
}
|
|
throw;
|
|
}
|
|
|
|
/* The files below are special-cased to that they don't show up
|
|
* in user profiles, either because they are useless, or
|
|
* because they would cauase pointless collisions (e.g., each
|
|
* Python package brings its own
|
|
* `$out/lib/pythonX.Y/site-packages/easy-install.pth'.)
|
|
*/
|
|
if (hasSuffix(srcFile, "/propagated-build-inputs") ||
|
|
hasSuffix(srcFile, "/nix-support") ||
|
|
hasSuffix(srcFile, "/perllocal.pod") ||
|
|
hasSuffix(srcFile, "/info/dir") ||
|
|
hasSuffix(srcFile, "/log"))
|
|
continue;
|
|
|
|
else if (S_ISDIR(srcSt.st_mode)) {
|
|
struct stat dstSt;
|
|
auto res = lstat(dstFile.c_str(), &dstSt);
|
|
if (res == 0) {
|
|
if (S_ISDIR(dstSt.st_mode)) {
|
|
createLinks(state, srcFile, dstFile, priority);
|
|
continue;
|
|
} else if (S_ISLNK(dstSt.st_mode)) {
|
|
auto target = canonPath(dstFile, true);
|
|
if (!S_ISDIR(lstat(target).st_mode))
|
|
throw Error("collision between '%1%' and non-directory '%2%'", srcFile, target);
|
|
if (unlink(dstFile.c_str()) == -1)
|
|
throw SysError("unlinking '%1%'", dstFile);
|
|
if (mkdir(dstFile.c_str(), 0755) == -1)
|
|
throw SysError("creating directory '%1%'", dstFile);
|
|
createLinks(state, target, dstFile, state.priorities[dstFile]);
|
|
createLinks(state, srcFile, dstFile, priority);
|
|
continue;
|
|
}
|
|
} else if (errno != ENOENT)
|
|
throw SysError("getting status of '%1%'", dstFile);
|
|
}
|
|
|
|
else {
|
|
struct stat dstSt;
|
|
auto res = lstat(dstFile.c_str(), &dstSt);
|
|
if (res == 0) {
|
|
if (S_ISLNK(dstSt.st_mode)) {
|
|
auto prevPriority = state.priorities[dstFile];
|
|
if (prevPriority == priority)
|
|
throw Error(
|
|
"packages '%1%' and '%2%' have the same priority %3%; "
|
|
"use 'nix-env --set-flag priority NUMBER INSTALLED_PKGNAME' "
|
|
"to change the priority of one of the conflicting packages"
|
|
" (0 being the highest priority)",
|
|
srcFile, readLink(dstFile), priority);
|
|
if (prevPriority < priority)
|
|
continue;
|
|
if (unlink(dstFile.c_str()) == -1)
|
|
throw SysError("unlinking '%1%'", dstFile);
|
|
} else if (S_ISDIR(dstSt.st_mode))
|
|
throw Error("collision between non-directory '%1%' and directory '%2%'", srcFile, dstFile);
|
|
} else if (errno != ENOENT)
|
|
throw SysError("getting status of '%1%'", dstFile);
|
|
}
|
|
|
|
createSymlink(srcFile, dstFile);
|
|
state.priorities[dstFile] = priority;
|
|
state.symlinks++;
|
|
}
|
|
}
|
|
|
|
void buildProfile(const Path & out, Packages && pkgs)
|
|
{
|
|
State state;
|
|
|
|
std::set<Path> done, postponed;
|
|
|
|
auto addPkg = [&](const Path & pkgDir, int priority) {
|
|
if (!done.insert(pkgDir).second) return;
|
|
createLinks(state, pkgDir, out, priority);
|
|
|
|
try {
|
|
for (const auto & p : tokenizeString<std::vector<string>>(
|
|
readFile(pkgDir + "/nix-support/propagated-user-env-packages"), " \n"))
|
|
if (!done.count(p))
|
|
postponed.insert(p);
|
|
} catch (SysError & e) {
|
|
if (e.errNo != ENOENT && e.errNo != ENOTDIR) throw;
|
|
}
|
|
};
|
|
|
|
/* Symlink to the packages that have been installed explicitly by the
|
|
* user. Process in priority order to reduce unnecessary
|
|
* symlink/unlink steps.
|
|
*/
|
|
std::sort(pkgs.begin(), pkgs.end(), [](const Package & a, const Package & b) {
|
|
return a.priority < b.priority || (a.priority == b.priority && a.path < b.path);
|
|
});
|
|
for (const auto & pkg : pkgs)
|
|
if (pkg.active)
|
|
addPkg(pkg.path, pkg.priority);
|
|
|
|
/* Symlink to the packages that have been "propagated" by packages
|
|
* installed by the user (i.e., package X declares that it wants Y
|
|
* installed as well). We do these later because they have a lower
|
|
* priority in case of collisions.
|
|
*/
|
|
auto priorityCounter = 1000;
|
|
while (!postponed.empty()) {
|
|
std::set<Path> pkgDirs;
|
|
postponed.swap(pkgDirs);
|
|
for (const auto & pkgDir : pkgDirs)
|
|
addPkg(pkgDir, priorityCounter++);
|
|
}
|
|
|
|
debug("created %d symlinks in user environment", state.symlinks);
|
|
}
|
|
|
|
void builtinBuildenv(const BasicDerivation & drv)
|
|
{
|
|
auto getAttr = [&](const string & name) {
|
|
auto i = drv.env.find(name);
|
|
if (i == drv.env.end()) throw Error("attribute '%s' missing", name);
|
|
return i->second;
|
|
};
|
|
|
|
Path out = getAttr("out");
|
|
createDirs(out);
|
|
|
|
/* Convert the stuff we get from the environment back into a
|
|
* coherent data type. */
|
|
Packages pkgs;
|
|
auto derivations = tokenizeString<Strings>(getAttr("derivations"));
|
|
while (!derivations.empty()) {
|
|
/* !!! We're trusting the caller to structure derivations env var correctly */
|
|
auto active = derivations.front(); derivations.pop_front();
|
|
auto priority = stoi(derivations.front()); derivations.pop_front();
|
|
auto outputs = stoi(derivations.front()); derivations.pop_front();
|
|
for (auto n = 0; n < outputs; n++) {
|
|
auto path = derivations.front(); derivations.pop_front();
|
|
pkgs.emplace_back(path, active != "false", priority);
|
|
}
|
|
}
|
|
|
|
buildProfile(out, std::move(pkgs));
|
|
|
|
createSymlink(getAttr("manifest"), out + "/manifest.nix");
|
|
}
|
|
|
|
}
|