"using namespace std" considered harmful

This commit is contained in:
Eelco Dolstra 2017-04-25 18:58:02 +02:00
parent 5bd8795e1f
commit 536f061765
No known key found for this signature in database
GPG key ID: 8170B4726D7198DE

View file

@ -19,8 +19,6 @@
namespace nix { namespace nix {
using namespace std;
#define ESC_RED "\033[31m" #define ESC_RED "\033[31m"
#define ESC_GRE "\033[32m" #define ESC_GRE "\033[32m"
#define ESC_YEL "\033[33m" #define ESC_YEL "\033[33m"
@ -70,7 +68,8 @@ struct NixRepl
void printHelp() void printHelp()
{ {
cout << "Usage: nix-repl [--help] [--version] [-I path] paths...\n" std::cout
<< "Usage: nix-repl [--help] [--version] [-I path] paths...\n"
<< "\n" << "\n"
<< "nix-repl is a simple read-eval-print loop (REPL) for the Nix package manager.\n" << "nix-repl is a simple read-eval-print loop (REPL) for the Nix package manager.\n"
<< "\n" << "\n"
@ -97,8 +96,7 @@ void printHelp()
<< " If an element of paths starts with http:// or https://, it is interpreted\n" << " If an element of paths starts with http:// or https://, it is interpreted\n"
<< " as the URL of a tarball that will be downloaded and unpacked to a temporary\n" << " as the URL of a tarball that will be downloaded and unpacked to a temporary\n"
<< " location. The tarball must include a single top-level directory containing\n" << " location. The tarball must include a single top-level directory containing\n"
<< " at least a file named default.nix.\n" << " at least a file named default.nix.\n";
<< flush;
} }
@ -351,7 +349,8 @@ bool NixRepl::processLine(string line)
} }
if (command == ":?" || command == ":help") { if (command == ":?" || command == ":help") {
cout << "The following commands are available:\n" std::cout
<< "The following commands are available:\n"
<< "\n" << "\n"
<< " <expr> Evaluate and print expression\n" << " <expr> Evaluate and print expression\n"
<< " <x> = <expr> Bind expression to variable\n" << " <x> = <expr> Bind expression to variable\n"