From 076844e3868f108ce0d1523e2db069f7e71c9990 Mon Sep 17 00:00:00 2001 From: eldritch horrors Date: Mon, 4 Mar 2024 07:27:52 +0100 Subject: [PATCH] Merge pull request #9621 from blaggacao/fix/too-restrictive-branch-regex-master fix: valid branch name (cherry picked from commit d2016c6b59f4a5223a18c92c817d61c448ce39ab) Change-Id: Ic346739b91bf1b10515c9ff3b3e180a64afe6343 --- src/libutil/url-parts.hh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libutil/url-parts.hh b/src/libutil/url-parts.hh index 12026921f..6255c1d02 100644 --- a/src/libutil/url-parts.hh +++ b/src/libutil/url-parts.hh @@ -25,7 +25,8 @@ const static std::string pathRegex = "(?:" + segmentRegex + "(?:/" + segmentRege /// A Git ref (i.e. branch or tag name). /// \todo check that this is correct. -const static std::string refRegexS = "[a-zA-Z0-9@][a-zA-Z0-9_.\\/@-]*"; +/// This regex incomplete. See https://git-scm.com/docs/git-check-ref-format +const static std::string refRegexS = "[a-zA-Z0-9@][a-zA-Z0-9_.\\/@+-]*"; extern std::regex refRegex; /// Instead of defining what a good Git Ref is, we define what a bad Git Ref is