nrabulinski/attic
1
1
Fork 1
Code Issues Pull requests Packages Projects Releases Wiki Activity

fix chunk deletion bug

Browse source 
fetch all deleted chunks, not just the ones that just transitioned
This commit is contained in:
Travis Staton 2023-06-24 12:31:38 -04:00
parent 4fedffe6a1
commit 91d8bd5cdc
No known key found for this signature in database
GPG key ID: 431DD911A00DAE49
1 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
server/src/gc.rs
View file

@ -177,16 +177,21 @@ async fn run_reap_orphan_chunks(state: &State) -> Result<()> {
// ... and transition their state to Deleted
//
// Deleted chunks are essentially invisible from our normal queries
let change_state = Query::update()
.table(Chunk)
.value(chunk::Column::State, ChunkState::Deleted)
.and_where(chunk::Column::Id.in_subquery(orphan_chunk_ids))
.returning_all()
.to_owned();
let transition_statement = {
let change_state = Query::update()
.table(Chunk)
.value(chunk::Column::State, ChunkState::Deleted)
.and_where(chunk::Column::Id.in_subquery(orphan_chunk_ids))
.to_owned();
db.get_database_backend().build(&change_state)
};
let stmt = db.get_database_backend().build(&change_state);
db.execute(transition_statement).await?;
let orphan_chunks = chunk::Model::find_by_statement(stmt).all(db).await?;
let orphan_chunks: Vec<chunk::Model> = Chunk::find()
.filter(chunk::Column::State.eq(ChunkState::Deleted))
.all(db)
.await?;
if orphan_chunks.is_empty() {
return Ok(());