Remove "killing process <pid>" messages

They convey no useful information.
This commit is contained in:
Eelco Dolstra 2017-03-16 10:52:28 +01:00
parent 43f158bb08
commit 0ec7f47b00
No known key found for this signature in database
GPG key ID: 8170B4726D7198DE
4 changed files with 6 additions and 11 deletions

View file

@ -331,13 +331,9 @@ RunPager::~RunPager()
close(STDOUT_FILENO);
pid.wait();
}
} catch (...) {
try {
pid.kill(true);
} catch (...) {
ignoreException();
}
}
}

View file

@ -642,7 +642,7 @@ HookInstance::~HookInstance()
{
try {
toHook.writeSide = -1;
if (pid != -1) pid.kill(true);
if (pid != -1) pid.kill();
} catch (...) {
ignoreException();
}
@ -1437,7 +1437,7 @@ void DerivationGoal::buildDone()
to have terminated. In fact, the builder could also have
simply have closed its end of the pipe, so just to be sure,
kill it. */
int status = hook ? hook->pid.kill(true) : pid.kill(true);
int status = hook ? hook->pid.kill() : pid.kill();
debug(format("builder process for %1% finished") % drvPath);

View file

@ -678,12 +678,11 @@ Pid::operator pid_t()
}
int Pid::kill(bool quiet)
int Pid::kill()
{
assert(pid != -1);
if (!quiet)
printError(format("killing process %1%") % pid);
debug(format("killing process %1%") % pid);
/* Send the requested signal to the child. If it has its own
process group, send the signal to every process in the child

View file

@ -203,7 +203,7 @@ public:
~Pid();
void operator =(pid_t pid);
operator pid_t();
int kill(bool quiet = false);
int kill();
int wait();
void setSeparatePG(bool separatePG);