ma27/hydra
0
0
Fork 0
forked from lix-project/hydra
Code Pull requests Activity

queue runner: fix nullptr deref on build exception after releasing a machine reservation

Browse source
This commit is contained in:
Pierre Bourdon 2024-07-13 06:12:35 +02:00
parent 05d620a54f
commit fb9e29d4d0
Signed by untrusted user: delroth
GPG key ID: 6FB80DCD84DA0F1C
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/hydra-queue-runner/builder.cc
View file

@ -37,11 +37,12 @@ void State::builder(MachineReservation::ptr reservation)
try { try {
auto destStore = getDestStore(); auto destStore = getDestStore();
// Might release the reservation.
res = doBuildStep(destStore, reservation, activeStep); res = doBuildStep(destStore, reservation, activeStep);
} catch (std::exception & e) { } catch (std::exception & e) {
printMsg(lvlError, "uncaught exception building ‘%s’ on ‘%s’: %s", printMsg(lvlError, "uncaught exception building ‘%s’ on ‘%s’: %s",
localStore->printStorePath(reservation->step->drvPath), localStore->printStorePath(activeStep->step->drvPath),
reservation->machine->sshName, reservation ? reservation->machine->sshName : std::string("(no machine)"),
e.what()); e.what());
} }
} }