From e5a4147f0a704c76d6d5777ee904aab95065b877 Mon Sep 17 00:00:00 2001 From: Graham Christensen Date: Wed, 17 Nov 2021 15:05:03 -0500 Subject: [PATCH 1/2] runcommand.t: stop dumping the json --- t/plugins/runcommand.t | 3 --- 1 file changed, 3 deletions(-) diff --git a/t/plugins/runcommand.t b/t/plugins/runcommand.t index 8a512b32..a010697c 100644 --- a/t/plugins/runcommand.t +++ b/t/plugins/runcommand.t @@ -46,9 +46,6 @@ my $dat = do { $json->decode(<$json_fh>) }; -use Data::Dumper; -print Dumper($dat); - subtest "Validate the top level fields match" => sub { is($dat->{build}, $newbuild->id, "The build event matches our expected ID."); is($dat->{buildStatus}, 0, "The build status matches."); From 5917de4948d97697b406218b9c8f3db0dc92e9ec Mon Sep 17 00:00:00 2001 From: Graham Christensen Date: Wed, 17 Nov 2021 14:20:52 -0500 Subject: [PATCH 2/2] t/plugins/runcommand.t: output the filename if it fails to open --- t/plugins/runcommand.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/plugins/runcommand.t b/t/plugins/runcommand.t index a010697c..deb59ffe 100644 --- a/t/plugins/runcommand.t +++ b/t/plugins/runcommand.t @@ -40,7 +40,7 @@ ok(sendNotifications(), "Notifications execute successfully."); my $dat = do { my $filename = $ENV{'HYDRA_DATA'} . "/joboutput.json"; open(my $json_fh, "<", $filename) - or die("Can't open \$filename\": $!\n"); + or die("Can't open \"$filename\": $!\n"); local $/; my $json = JSON->new; $json->decode(<$json_fh>)