ma27/hydra
0
0
Fork 0
forked from lix-project/hydra
Code Pull requests Activity

Fix restarting builds

Browse source 
Failed paths were not cleared because the $builds query becomes empty
as soon as the "finished" flag has been cleared. So this needs to be
done last.
This commit is contained in:
Eelco Dolstra 2015-10-28 14:54:54 +01:00
parent bbe1fb2f9f
commit b9ebd38edf
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/lib/Hydra/Helper/Nix.pm
View file

@ -453,11 +453,6 @@ sub restartBuilds($$) {
my $nrRestarted = 0; my $nrRestarted = 0;
txn_do($db, sub { txn_do($db, sub {
$nrRestarted = $builds->update(
{ finished => 0
, iscachedbuild => 0
});
# Reset the stats for the evals to which the builds belongs. # Reset the stats for the evals to which the builds belongs.
# !!! Should do this in a trigger. # !!! Should do this in a trigger.
$db->resultset('JobsetEvals')->search( $db->resultset('JobsetEvals')->search(
@ -473,6 +468,11 @@ sub restartBuilds($$) {
{ path => { -in => $builds->search({}, { join => "buildstepoutputs", select => "buildstepoutputs.path", as => "path", distinct => 1 })->as_query } { path => { -in => $builds->search({}, { join => "buildstepoutputs", select => "buildstepoutputs.path", as => "path", distinct => 1 })->as_query }
})->delete; })->delete;
print STDERR "cleared $cleared failed paths\n"; print STDERR "cleared $cleared failed paths\n";
$nrRestarted = $builds->update(
{ finished => 0
, iscachedbuild => 0
});
}); });
return $nrRestarted; return $nrRestarted;