From 7f865a30d555c0d244fb52f05e351f9ab53be3c9 Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Fri, 10 Jul 2015 16:44:06 +0200 Subject: [PATCH] hydra-evaluator: Fix input change check Because inputs were processed in random order by inputsToArgs, the inputs hash could be different every time, leading to unnecessary re-evaluations. --- src/lib/Hydra/Helper/AddBuilds.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/Hydra/Helper/AddBuilds.pm b/src/lib/Hydra/Helper/AddBuilds.pm index 3fcd6cc0..70fb96f4 100644 --- a/src/lib/Hydra/Helper/AddBuilds.pm +++ b/src/lib/Hydra/Helper/AddBuilds.pm @@ -277,7 +277,7 @@ sub inputsToArgs { my ($inputInfo, $exprType) = @_; my @res = (); - foreach my $input (keys %{$inputInfo}) { + foreach my $input (sort keys %{$inputInfo}) { push @res, "-I", "$input=$inputInfo->{$input}->[0]->{storePath}" if scalar @{$inputInfo->{$input}} == 1 && defined $inputInfo->{$input}->[0]->{storePath};