From 66375fd2d902292135a724470950c167e5a72dc3 Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Mon, 27 Sep 2021 17:42:56 +0200 Subject: [PATCH] Fix 'Error loading tab: 0 error' with uBlock Origin /metrics-tab matches a rule in one of uBlock Origin's default blocklists, so let's name it something else. --- src/lib/Hydra/Controller/Job.pm | 2 +- src/root/job.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/Hydra/Controller/Job.pm b/src/lib/Hydra/Controller/Job.pm index a9e65f76..becd364b 100644 --- a/src/lib/Hydra/Controller/Job.pm +++ b/src/lib/Hydra/Controller/Job.pm @@ -144,7 +144,7 @@ sub overview : Chained('job') PathPart('') Args(0) { } -sub metrics_tab : Chained('job') PathPart('metrics-tab') Args(0) { +sub metrics_tab : Chained('job') PathPart('metric-tab') Args(0) { my ($self, $c) = @_; $c->stash->{template} = 'job-metrics-tab.tt'; $c->stash->{metrics} = [ $c->stash->{jobset}->buildmetrics->search( diff --git a/src/root/job.tt b/src/root/job.tt index 79853183..e8a56569 100644 --- a/src/root/job.tt +++ b/src/root/job.tt @@ -84,7 +84,7 @@ removed or had an evaluation error. [% END %] - [% INCLUDE makeLazyTab tabName="tabs-charts" uri=c.uri_for('/job' project.name jobset.name job 'metrics-tab') %] + [% INCLUDE makeLazyTab tabName="tabs-charts" uri=c.uri_for('/job' project.name jobset.name job 'metric-tab') %]