ma27/hydra
0
0
Fork 0
forked from lix-project/hydra
Code Pull requests Activity

GitInput: only convert integer option values to int

Browse source 
The previous code converted option values to ints when the value
contained a digit somewhere. This is too eager since it also converts
strings like `release-0.2` to an int which should not happen.

We now only convert to int when the value is an integer.
This commit is contained in:
Bas van Dijk 2020-05-13 11:41:52 +02:00
parent 15a45f1a8a
commit 38122544ed
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/lib/Hydra/Plugin/GitInput.pm
View file

@ -118,7 +118,7 @@ sub fetchInput {
$name); $name);
# give preference to the options from the input value # give preference to the options from the input value
while (my ($opt_name, $opt_value) = each %{$options}) { while (my ($opt_name, $opt_value) = each %{$options}) {
if ($opt_value =~ /\d+/) { if ($opt_value =~ /^[+-]?\d+\z/) {
$opt_value = int($opt_value); $opt_value = int($opt_value);
} }
$cfg->{$opt_name} = $opt_value; $cfg->{$opt_name} = $opt_value;