ma27/hydra
0
0
Fork 0
forked from lix-project/hydra
Code Pull requests Activity

RunCommand: remove unused and problematic imports

Browse source 
Since breaking the filename construction out to a helper function,
Hydra::Model::DB is no longer used. Importing Hydra::Helper::Nix,
however, has the potential to break tests, so just use the functions we
need without importing the entire module.
This commit is contained in:
Cole Helbling 2022-01-25 12:10:43 -08:00
parent fdf6f4d3da
commit 244300c1ad
1 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/lib/Hydra/Plugin/RunCommand.pm
View file

@ -5,9 +5,6 @@ use warnings;
use parent 'Hydra::Plugin';
use experimental 'smartmatch';
use JSON::MaybeXS;
use Digest::SHA1 qw(sha1_hex);
use Hydra::Model::DB;
use Hydra::Helper::Nix;
use File::Basename qw(dirname);
use File::Path qw(make_path);
use IPC::Run3;
@ -166,8 +163,8 @@ sub buildFinished {
$runlog->started();
my $filename = constructRunCommandLogFilename(sha1_hex($command), $build->get_column('id'));
my $logPath = constructRunCommandLogPath($filename);
my $filename = Hydra::Helper::Nix::constructRunCommandLogFilename(sha1_hex($command), $build->get_column('id'));
my $logPath = Hydra::Helper::Nix::constructRunCommandLogPath($filename);
my $dir = dirname($logPath);
my $oldUmask = umask();