ma27/hydra
0
0
Fork 0
forked from lix-project/hydra
Code Pull requests Activity

RunCommand: only run dynamic runcommand hooks if the project AND jobset agree they should be enabled

Browse source
This commit is contained in:
Graham Christensen 2021-12-15 12:33:16 -05:00
parent 85a53694c8
commit 0c96172c28
1 changed files with 33 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
t/Hydra/Plugin/RunCommand/fanout.t
View file

@ -13,7 +13,8 @@ my $builds = $ctx->makeAndEvaluateJobset(
my $build = $builds->{"runCommandHook.example"}; my $build = $builds->{"runCommandHook.example"};
# Enable dynamic runcommand on the jobset # Enable dynamic runcommand on the project and jobset
$build->project->update({enable_dynamic_run_command => 1});
$build->jobset->update({enable_dynamic_run_command => 1}); $build->jobset->update({enable_dynamic_run_command => 1});
is($build->job, "runCommandHook.example", "The only job should be runCommandHook.example"); is($build->job, "runCommandHook.example", "The only job should be runCommandHook.example");
@ -172,13 +173,38 @@ subtest "isBuildEligibleForDynamicRunCommand" => sub {
}; };
subtest "With dynamic runcommand disabled ..." => sub { subtest "With dynamic runcommand disabled ..." => sub {
$build->jobset->update({enable_dynamic_run_command => 0}); subtest "disabled on the project, enabled on the jobset" => {
$build->project->update({enable_dynamic_run_command => 0});
$build->jobset->update({enable_dynamic_run_command => 1});
is( is(
Hydra::Plugin::RunCommand::isBuildEligibleForDynamicRunCommand($builds->{"runCommandHook.example"}), Hydra::Plugin::RunCommand::isBuildEligibleForDynamicRunCommand($builds->{"runCommandHook.example"}),
0, 0,
"Builds don't run from a jobset with disabled dynamic runcommand" "Builds don't run from a jobset with disabled dynamic runcommand"
); );
};
subtest "enabled on the project, disabled on the jobset" => {
$build->project->update({enable_dynamic_run_command => 1});
$build->jobset->update({enable_dynamic_run_command => 0});
is(
Hydra::Plugin::RunCommand::isBuildEligibleForDynamicRunCommand($builds->{"runCommandHook.example"}),
0,
"Builds don't run from a jobset with disabled dynamic runcommand"
);
};
subtest "disabled on the project, disabled on the jobset" => {
$build->project->update({enable_dynamic_run_command => 0});
$build->jobset->update({enable_dynamic_run_command => 0});
is(
Hydra::Plugin::RunCommand::isBuildEligibleForDynamicRunCommand($builds->{"runCommandHook.example"}),
0,
"Builds don't run from a jobset with disabled dynamic runcommand"
);
};
}; };
}; };