A modern, delicious implementation of the Nix package manager, focused on correctness, usability, and growth — and committed to doing right by its community
Find a file
Eelco Dolstra c536e00c9d Move pseudoterminal slave open to child
Hopefully this fixes "unexpected EOF" failures on macOS
(#3137, #3605, #7242, #7702).

The problem appears to be that under some circumstances, macOS
discards the output written to the slave side of the
pseudoterminal. Hence the parent never sees the "sandbox initialized"
message from the child, even though it succeeded. The conditions are:

* The child finishes very quickly. That's why this bug is likely to
  trigger in nix-env tests, since that uses a builtin builder. Adding
  a short sleep before the child exits makes the problem go away.

* The parent has closed its duplicate of the slave file
  descriptor. This shouldn't matter, since the child has a duplicate
  as well, but it does. E.g. moving the close to the bottom of
  startBuilder() makes the problem go away. However, that's not a
  solution because it would make Nix hang if the child dies before
  sending the "sandbox initialized" message.

* The system is under high load. E.g. "make installcheck -j16" makes
  the issue pretty reproducible, while it's very rare under "make
  installcheck -j1".

As a fix/workaround, we now open the pseudoterminal slave in the
child, rather than the parent. This removes the second condition
(i.e. the parent no longer needs to close the slave fd) and I haven't
been able to reproduce the "unexpected EOF" with this.
2023-03-15 10:58:37 +01:00
.github add labeler workflow 2023-03-13 18:01:21 +02:00
config Run autoupdate 2021-06-01 11:42:38 +02:00
contrib function-trace: always show the trace 2019-09-18 23:23:21 +02:00
doc Merge pull request #8036 from Freed-Wu/patch-1 2023-03-13 14:35:09 +01:00
m4 autoconf: Fix C++17 detection not working on Ubuntu 16.04. 2019-07-03 04:32:25 +02:00
maintainers Merge pull request #7534 from fricklerhandwerk/maintainers-goals 2023-03-13 14:01:15 +01:00
misc Merge pull request #6645 from Artturin/limitinfinity 2022-12-09 13:36:13 +01:00
mk Harden tests' bash 2023-03-08 10:26:30 -05:00
perl Fix building with GCC 9 2023-02-10 18:38:57 +01:00
scripts Merge pull request #7925 from cole-h/fixup-xdg-nix-env 2023-03-01 23:01:42 +01:00
src Move pseudoterminal slave open to child 2023-03-15 10:58:37 +01:00
tests Merge pull request #8033 from lbodor/stop-adding-dot-to-nix-dev-env-path 2023-03-13 19:52:41 +01:00
.dir-locals.el .dir-locals.el: Set c-block-comment-prefix 2020-07-10 11:21:06 +02:00
.editorconfig Add .editorconfig 2017-06-05 22:57:28 +01:00
.gitignore Clean up daemon handling 2023-02-23 11:31:44 -05:00
.version Bump version 2023-03-02 10:01:24 +01:00
boehmgc-coroutine-sp-fallback.diff Revert "Disable GC during coroutine execution + test" 2023-03-08 20:47:52 +01:00
bootstrap.sh bootstrap: Simplify & make more robust. 2011-09-06 12:11:05 +00:00
configure.ac Generate API docs with Doxygen 2023-03-10 12:51:06 -05:00
COPYING * Change this to LGPL to keep the government happy. 2006-04-25 16:41:06 +00:00
default.nix Remove url literals 2022-01-24 13:28:21 +01:00
docker.nix Add nobody user/group to Nix docker image 2022-11-29 10:01:46 +00:00
flake.lock flake.lock: Update 2022-12-08 17:09:50 +01:00
flake.nix Generate API docs with Doxygen 2023-03-10 12:51:06 -05:00
local.mk Remove 'dist' target 2020-12-03 16:17:58 +01:00
Makefile Generate API docs with Doxygen 2023-03-10 12:51:06 -05:00
Makefile.config.in Generate API docs with Doxygen 2023-03-10 12:51:06 -05:00
precompiled-headers.h Config: Use nlohmann/json 2020-08-20 11:02:16 +02:00
README.md Improve hacking.md 2023-02-13 12:00:00 +04:00
shell.nix Remove url literals 2022-01-24 13:28:21 +01:00

Nix

Open Collective supporters Test

Nix is a powerful package manager for Linux and other Unix systems that makes package management reliable and reproducible. Please refer to the Nix manual for more details.

Installation

On Linux and macOS the easiest way to install Nix is to run the following shell command (as a user other than root):

$ curl -L https://nixos.org/nix/install | sh

Information on additional installation methods is available on the Nix download page.

Building And Developing

See our Hacking guide in our manual for instruction on how to to set up a development environment and build Nix from source.

Additional Resources

License

Nix is released under the LGPL v2.1.