Eelco Dolstra 8d4268d190 Improve error formatting ... Changes: * The divider lines are gone. These were in practice a bit confusing, in particular with --show-trace or --keep-going, since then there were multiple lines, suggesting a start/end which wasn't the case. * Instead, multi-line error messages are now indented to align with the prefix (e.g. "error: "). * The 'description' field is gone since we weren't really using it. * 'hint' is renamed to 'msg' since it really wasn't a hint. * The error is now printed *before* the location info. * The 'name' field is no longer printed since most of the time it wasn't very useful since it was just the name of the exception (like EvalError). Ideally in the future this would be a unique, easily googleable error ID (like rustc). * "trace:" is now just "…". This assumes error contexts start with something like "while doing X". Example before: error: --- AssertionError ---------------------------------------------------------------------------------------- nix at: (7:7) in file: /home/eelco/Dev/nixpkgs/pkgs/applications/misc/hello/default.nix 6| 7| x = assert false; 1; | ^ 8| assertion 'false' failed ----------------------------------------------------- show-trace ----------------------------------------------------- trace: while evaluating the attribute 'x' of the derivation 'hello-2.10' at: (192:11) in file: /home/eelco/Dev/nixpkgs/pkgs/stdenv/generic/make-derivation.nix 191| // (lib.optionalAttrs (!(attrs ? name) && attrs ? pname && attrs ? version)) { 192| name = "${attrs.pname}-${attrs.version}"; | ^ 193| } // (lib.optionalAttrs (stdenv.hostPlatform != stdenv.buildPlatform && !dontAddHostSuffix && (attrs ? name || (attrs ? pname && attrs ? version)))) { Example after: error: assertion 'false' failed at: (7:7) in file: /home/eelco/Dev/nixpkgs/pkgs/applications/misc/hello/default.nix 6| 7| x = assert false; 1; | ^ 8| … while evaluating the attribute 'x' of the derivation 'hello-2.10' at: (192:11) in file: /home/eelco/Dev/nixpkgs/pkgs/stdenv/generic/make-derivation.nix 191| // (lib.optionalAttrs (!(attrs ? name) && attrs ? pname && attrs ? version)) { 192| name = "${attrs.pname}-${attrs.version}"; | ^ 193| } // (lib.optionalAttrs (stdenv.hostPlatform != stdenv.buildPlatform && !dontAddHostSuffix && (attrs ? name || (attrs ? pname && attrs ? version)))) {		2021-01-21 11:02:09 +01:00
..
compression.cc	Add compression unit tests	2020-06-08 11:34:37 +02:00
config.cc	Fix test	2020-10-30 12:00:53 +01:00
hash.cc	Revert the enum struct change	2020-06-18 22:11:26 +00:00
json.cc	Add unit tests for "json.hh"	2020-05-25 11:57:45 +02:00
local.mk	Add tests for logging.hh	2020-06-06 10:22:32 +02:00
logging.cc	Improve error formatting	2021-01-21 11:02:09 +01:00
lru-cache.cc	src/libutil/tests/lru-cache.cc: Check erase()	2020-06-02 12:06:59 +02:00
pool.cc	Add tests for pool.hh	2020-06-10 22:29:50 +02:00
tests.cc	Fix tests	2021-01-08 14:17:06 +01:00
url.cc	Add unit testes for url.cc	2020-05-20 16:37:35 +02:00
xml-writer.cc	Add unit tests for xml-writer	2020-05-25 18:34:55 +02:00