lix-project/nixos-module
17
11
Fork 22
Code Issues 9 Pull requests 1 Projects Releases Packages Wiki Activity

nixos-option: override no longer needed? #47

New issue
Open
opened 2025-01-19 21:29:29 +00:00 by christoph-heiss · 1 comment
christoph-heiss commented 2025-01-19 21:29:29 +00:00
Copy link

Hi!

Since the nixos-option rewrite as a simple nix script/evaluation has been merged on 07-01-2025, the overlay could be potentially drop that upstream override? Aka. this line.

Didn't look to closely at the implementation, but I've seen no reason why it wouldn't work.
Just wanted to file this for awareness, to see if there are plans w.r.t that.

Hi! Since the nixos-option rewrite as a simple nix script/evaluation has been [merged](https://github.com/NixOS/nixpkgs/pull/369151) on 07-01-2025, the overlay could be potentially drop that upstream override? Aka. [this line](https://git.lix.systems/lix-project/nixos-module/src/commit/690f7c0fa2935bf591cccf4d7312b3e0f470298b/overlay.nix#L18). Didn't look _to closely_ at the implementation, but I've seen no reason why it wouldn't work. Just wanted to file this for awareness, to see if there are plans w.r.t that.
jade commented 2025-01-19 22:28:45 +00:00
Owner
Copy link

We can only nuke it once it's in both supported branches, but thanks for raising this issue. It might be reasonable to backport the changes to 24.11 if only because it makes our lives easier by providing a lix based nixos-option on all supported versions.

We can only nuke it once it's in both supported branches, but thanks for raising this issue. It might be reasonable to backport the changes to 24.11 if only because it makes our lives easier by providing a lix based nixos-option on all supported versions.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
release-2.93
release-2.92
release-2.91
fix-nixpkgs-lix
fix-editline-overlay
stable
jade/bork
release-2.90
fix-build-release-notes
fix-prefetch-npm-deps
flake-input-with-git
nogit-urls
flake-input-https
2.93.2-1
2.92.3-1
2.91.3-1
2.91.2-1
2.92.2-1
2.93.1
2.93.0
2.92.0-3
2.92.0-2
2.91.1-3
2.92.0-1
2.92.0
2.91.1-2
2.91.1-1
2.91.1
2.91.0
2.90.0
2.90.0-rc1
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/nixos-module#47
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?