lix-project/nixos-module
16
3
Fork 11
Code Issues Pull requests Packages Projects Releases Wiki Activity

Delete prefetch-npm-deps hack since we dropped 23.11 #31

Merged
jade merged 1 commit from jade/fix-prefetchnpmdeps-hacks into main 2024-07-11 11:02:59 +00:00 AGit
Conversation 2 Commits 1 Files changed 1 -12
jade commented 2024-06-27 20:35:28 +00:00
Owner
Copy link

The fix upstream is in 24.05 at release, so no need for the hack
anymore.
ddb94deafa

The fix upstream is in 24.05 at release, so no need for the hack anymore. https://github.com/NixOS/nixpkgs/commit/ddb94deafad959c7a3ad1e34bbf2184fcec1a0f9
jade added 1 commit 2024-06-27 20:35:28 +00:00 
The fix upstream is in 24.05 at release, so no need for the hack
anymore.
ddb94deafa
jade requested review from piegames 2024-06-27 20:35:42 +00:00
lunaphied commented 2024-07-07 20:38:35 +00:00
Owner
Copy link

This should be fine as long as we only care about 24.05 and later going forward. Did we write that down somewhere? Since I'm sure lots of people are still running 23.11 (such as most of our servers) and probably aren't expecting this to suddenly break on them.

This should be fine as long as we only care about 24.05 and later going forward. Did we write that down somewhere? Since I'm sure lots of people are still running 23.11 (such as most of our servers) and probably aren't expecting this to suddenly break on them.
jade commented 2024-07-11 11:02:45 +00:00
Author
Owner
Copy link

Nope 23.11 is EOL and not receiving security patches. Our servers were updated a few weeks ago.

Nope 23.11 is EOL and not receiving security patches. Our servers were updated a few weeks ago.
jade merged commit d70318fb94 into main 2024-07-11 11:02:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
piegames
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/nixos-module#31
No description provided.
Delete branch "jade/fix-prefetchnpmdeps-hacks"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?