lix-project/nixos-module
16
2
Fork 9
Code Issues 1 Pull requests 1 Packages Projects Releases Wiki Activity

Don't pass in 'false' as the value of build-release-notes (a drv) #28

Merged
jade merged 1 commit from midnightveil/nixos-module:build-release-notes-is-a-drv into main 2024-05-16 02:03:53 +00:00
Conversation 1 Commits 1 Files changed 1 -1
midnightveil commented 2024-05-16 01:30:03 +00:00
Member
Copy link

7cfaf057e35b7bb329ffff344e30fdfc850566c3 in lix-project changed the
default there to always build the release notes anyway.

This argument caused failures to build, as false is not a derivation. Would need to be buildUnreleasedNotes.

[7cfaf057e35b7bb329ffff344e30fdfc850566c3](https://git.lix.systems/lix-project/lix/commit/7cfaf057e35b7bb329ffff344e30fdfc850566c3) in lix-project changed the default there to always build the release notes anyway. This argument caused failures to build, as false is not a derivation. Would need to be `buildUnreleasedNotes`.
midnightveil added 1 commit 2024-05-16 01:30:09 +00:00 
7cfaf057e35b7bb329ffff344e30fdfc850566c3 in lix-project changed the
default there to always build the release notes anyway, so this
caused failures to build, as false is not a derivation.
jade merged commit fbc1c1c4da into main 2024-05-16 02:03:53 +00:00
jade commented 2024-05-16 02:04:02 +00:00
Owner
Copy link

yeah busted, we should not do that.

yeah busted, we should not do that.
midnightveil deleted branch build-release-notes-is-a-drv 2024-05-16 02:04:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: lix-project/nixos-module#28
No description provided.
Delete branch "midnightveil/nixos-module:build-release-notes-is-a-drv"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?