prefetch-npm-deps override does not work correctly on 23.11, causing rebuilds #24

New issue

Closed

opened 2024-05-06 11:15:43 +00:00 by midnightveil · 3 comments

midnightveil commented

2024-05-06 11:15:43 +00:00

Member

The code added in commit 04186bcae3 which conditionally overrides the arguments to prefetch-npm-deps does not work on nixos-23.11.

    if (lib.functionArgs prev.prefetch-npm-deps.override) ? nix

This appears to be because pkgs.callPackages (how prefetch-npm-deps appears in all-packages.nix) did not propagate the function arguments correctly until nixpkgs commit 741377, which appears to not have been backported to 23.11.

nix-repl> lib.functionArgs (pkgs.unstable.prefetch-npm-deps.override)
{
  cacert = false;
  curl = false;
  fetchNpmDeps = false;
  /* elided for clarity */
}

nix-repl> lib.functionArgs (pkgs.prefetch-npm-deps.override)          
{ }

My solution was just to force the override in an overlay myself, though this is not optimal.

prefetch-npm-deps = prev.prefetch-npm-deps.override {
  nix = final.nixVersions.nix_2_18_upstream;
};

The code added in commit 04186bcae389b43c3ed8e4054068eb520b3f2349 which conditionally overrides the arguments to `prefetch-npm-deps` does not work on nixos-23.11. ```nix if (lib.functionArgs prev.prefetch-npm-deps.override) ? nix ``` This appears to be because `pkgs.callPackages` (how `prefetch-npm-deps` appears in all-packages.nix) did not propagate the function arguments correctly until nixpkgs commit [741377](https://github.com/NixOS/nixpkgs/commit/741377b30058c5742e5ae08b1d8a85bcc9aa6d55), which appears to not have been backported to 23.11. ``` nix-repl> lib.functionArgs (pkgs.unstable.prefetch-npm-deps.override) { cacert = false; curl = false; fetchNpmDeps = false; /* elided for clarity */ } nix-repl> lib.functionArgs (pkgs.prefetch-npm-deps.override) { } ``` My solution was just to force the override in an overlay myself, though this is not optimal. ```nix prefetch-npm-deps = prev.prefetch-npm-deps.override { nix = final.nixVersions.nix_2_18_upstream; }; ```