f7f37035c8
Today, with the tests inside a `tests` intermingled with the
corresponding library's source code, we have a few problems:
- We have to be careful that wildcards don't end up with tests being
built as part of Nix proper, or test headers being installed as part
of Nix proper.
- Tests in libraries but not executables is not right:
- It means each executable runs the previous unit tests again, because
it needs the libraries.
- It doesn't work right on Windows, which doesn't want you to load a
DLL just for the side global variable . It could be made to work
with the dlopen equivalent, but that's gross!
This reorg solves these problems.
There is a remaining problem which is that sibbling headers (like
`hash.hh` the test header vs `hash.hh` the main `libnixutil` header) end
up shadowing each other. This PR doesn't solve that. That is left as
future work for a future PR.
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
(cherry picked from commit 91b6833686a6a6d9eac7f3f66393ec89ef1d3b57)
(cherry picked from commit a61e42adb528b3d40ce43e07c79368d779a8b624)
47 lines
1.2 KiB
C++
47 lines
1.2 KiB
C++
#include "references.hh"
|
|
#include <gtest/gtest.h>
|
|
|
|
namespace nix {
|
|
|
|
using std::string;
|
|
|
|
struct RewriteParams {
|
|
string originalString, finalString;
|
|
StringMap rewrites;
|
|
|
|
friend std::ostream& operator<<(std::ostream& os, const RewriteParams& bar) {
|
|
StringSet strRewrites;
|
|
for (auto & [from, to] : bar.rewrites)
|
|
strRewrites.insert(from + "->" + to);
|
|
return os <<
|
|
"OriginalString: " << bar.originalString << std::endl <<
|
|
"Rewrites: " << concatStringsSep(",", strRewrites) << std::endl <<
|
|
"Expected result: " << bar.finalString;
|
|
}
|
|
};
|
|
|
|
class RewriteTest : public ::testing::TestWithParam<RewriteParams> {
|
|
};
|
|
|
|
TEST_P(RewriteTest, IdentityRewriteIsIdentity) {
|
|
RewriteParams param = GetParam();
|
|
StringSink rewritten;
|
|
auto rewriter = RewritingSink(param.rewrites, rewritten);
|
|
rewriter(param.originalString);
|
|
rewriter.flush();
|
|
ASSERT_EQ(rewritten.s, param.finalString);
|
|
}
|
|
|
|
INSTANTIATE_TEST_CASE_P(
|
|
references,
|
|
RewriteTest,
|
|
::testing::Values(
|
|
RewriteParams{ "foooo", "baroo", {{"foo", "bar"}, {"bar", "baz"}}},
|
|
RewriteParams{ "foooo", "bazoo", {{"fou", "bar"}, {"foo", "baz"}}},
|
|
RewriteParams{ "foooo", "foooo", {}}
|
|
)
|
|
);
|
|
|
|
}
|
|
|