c11836126b
Use `set -u` and `set -o pipefail` to catch accidental mistakes and failures more strongly. - `set -u` catches the use of undefined variables - `set -o pipefail` catches failures (like `set -e`) earlier in the pipeline. This makes the tests a bit more robust. It is nice to read code not worrying about these spurious success paths (via uncaught) errors undermining the tests. Indeed, I caught some bugs doing this. There are a few tests where we run a command that should fail, and then search its output to make sure the failure message is one that we expect. Before, since the `grep` was the last command in the pipeline the exit code of those failing programs was silently ignored. Now with `set -o pipefail` it won't be, and we have to do something so the expected failure doesn't accidentally fail the test. To do that we use `expect` and a new `expectStderr` to check for the exact failing exit code. See the comments on each for why. `grep -q` is replaced with `grepQuiet`, see the comments on that function for why. `grep -v` when we just want the exit code is replaced with `grepInverse, see the comments on that function for why. `grep -q -v` together is, surprise surprise, replaced with `grepQuietInverse`, which is both combined. Co-authored-by: Robert Hensing <roberth@users.noreply.github.com>
106 lines
3.2 KiB
Bash
106 lines
3.2 KiB
Bash
source common.sh
|
||
|
||
clearStore
|
||
|
||
cd "$TEST_ROOT"
|
||
|
||
test_fetch_file () {
|
||
echo foo > test_input
|
||
|
||
input_hash="$(nix hash path test_input)"
|
||
|
||
nix eval --impure --file - <<EOF
|
||
let
|
||
tree = builtins.fetchTree { type = "file"; url = "file://$PWD/test_input"; };
|
||
in
|
||
assert (tree.narHash == "$input_hash");
|
||
tree
|
||
EOF
|
||
}
|
||
|
||
# Make sure that `http(s)` and `file` flake inputs are properly extracted when
|
||
# they should be, and treated as opaque files when they should be
|
||
test_file_flake_input () {
|
||
rm -fr "$TEST_ROOT/testFlake";
|
||
mkdir "$TEST_ROOT/testFlake";
|
||
pushd testFlake
|
||
|
||
mkdir inputs
|
||
echo foo > inputs/test_input_file
|
||
tar cfa test_input.tar.gz inputs
|
||
cp test_input.tar.gz test_input_no_ext
|
||
input_tarball_hash="$(nix hash path test_input.tar.gz)"
|
||
input_directory_hash="$(nix hash path inputs)"
|
||
|
||
cat <<EOF > flake.nix
|
||
{
|
||
inputs.no_ext_default_no_unpack = {
|
||
url = "file://$PWD/test_input_no_ext";
|
||
flake = false;
|
||
};
|
||
inputs.no_ext_explicit_unpack = {
|
||
url = "tarball+file://$PWD/test_input_no_ext";
|
||
flake = false;
|
||
};
|
||
inputs.tarball_default_unpack = {
|
||
url = "file://$PWD/test_input.tar.gz";
|
||
flake = false;
|
||
};
|
||
inputs.tarball_explicit_no_unpack = {
|
||
url = "file+file://$PWD/test_input.tar.gz";
|
||
flake = false;
|
||
};
|
||
outputs = { ... }: {};
|
||
}
|
||
EOF
|
||
|
||
nix flake update
|
||
nix eval --file - <<EOF
|
||
with (builtins.fromJSON (builtins.readFile ./flake.lock));
|
||
|
||
# Url inputs whose extension doesn’t match a known archive format should
|
||
# not be unpacked by default
|
||
assert (nodes.no_ext_default_no_unpack.locked.type == "file");
|
||
assert (nodes.no_ext_default_no_unpack.locked.unpack or false == false);
|
||
assert (nodes.no_ext_default_no_unpack.locked.narHash == "$input_tarball_hash");
|
||
|
||
# For backwards compatibility, flake inputs that correspond to the
|
||
# old 'tarball' fetcher should still have their type set to 'tarball'
|
||
assert (nodes.tarball_default_unpack.locked.type == "tarball");
|
||
# Unless explicitely specified, the 'unpack' parameter shouldn’t appear here
|
||
# because that would break older Nix versions
|
||
assert (!nodes.tarball_default_unpack.locked ? unpack);
|
||
assert (nodes.tarball_default_unpack.locked.narHash == "$input_directory_hash");
|
||
|
||
# Explicitely passing the unpack parameter should enforce the desired behavior
|
||
assert (nodes.no_ext_explicit_unpack.locked.narHash == nodes.tarball_default_unpack.locked.narHash);
|
||
assert (nodes.tarball_explicit_no_unpack.locked.narHash == nodes.no_ext_default_no_unpack.locked.narHash);
|
||
true
|
||
EOF
|
||
popd
|
||
|
||
[[ -z "${NIX_DAEMON_PACKAGE-}" ]] && return 0
|
||
|
||
# Ensure that a lockfile generated by the current Nix for tarball inputs
|
||
# can still be read by an older Nix
|
||
|
||
cat <<EOF > flake.nix
|
||
{
|
||
inputs.tarball = {
|
||
url = "file://$PWD/test_input.tar.gz";
|
||
flake = false;
|
||
};
|
||
outputs = { self, tarball }: {
|
||
foo = builtins.readFile "\${tarball}/test_input_file";
|
||
};
|
||
}
|
||
nix flake update
|
||
|
||
clearStore
|
||
"$NIX_DAEMON_PACKAGE/bin/nix" eval .#foo
|
||
EOF
|
||
}
|
||
|
||
test_fetch_file
|
||
test_file_flake_input
|