lix-project/lix
20
57
Fork 31
Code Issues 347 Code Review (Gerrit) Projects 3 Releases Wiki Activity
lix/tests/functional2
History
jade 822997bd34 libstore: ban unpacking case hacked filenames from NARs 
There is absolutely no good reason these should show up in NARs besides
misconfigured systems and as long as the case hack exists, unpacking
such a NAR will cause its repacking to be wrong on systems with case
hack enabled.

This should not have any security impact on Lix to fix, but it was one
of the vectors for CVE-2024-45593:
https://github.com/NixOS/nix/security/advisories/GHSA-h4vv-h3jq-v493

Change-Id: I85b6075aacc069ee7039240b0f525804a2d8edcb
2024-10-09 14:47:39 -07:00
..
store libstore: ban unpacking case hacked filenames from NARs 2024-10-09 14:47:39 -07:00
testlib testsuite: add a NAR generator with some evil NARs 2024-10-09 14:47:39 -07:00
__init__.py testsuite: add a functional2 test suite based on pytest 2024-10-09 14:47:39 -07:00
conftest.py testsuite: add a functional2 test suite based on pytest 2024-10-09 14:47:39 -07:00
meson.build testsuite: use xdist for parallel test running 2024-10-09 14:47:39 -07:00
README.md testsuite: use xdist for parallel test running 2024-10-09 14:47:39 -07:00
test_eval_trivial.py testsuite: add a functional2 test suite based on pytest 2024-10-09 14:47:39 -07:00

README.md

functional2 tests

This uncreatively named test suite is a Pytest based replacement for the shell framework used to write traditional Nix integration tests. Its primary goal is to make tests more concise, more self-contained, easier to write, and to produce better errors.

Goals

  • Eliminate implicit dependencies on files in the test directory as well as the requirement to copy the test files to the build directory as is currently hacked in the other functional test suite.
    • You should be able to write a DirectoryTree of files for your test declaratively.
  • Reduce the amount of global environment state being thrown around in the test suite.
  • Make tests very concise and easy to reuse code for, and hopefully turn more of what is currently code into data.
    • Provide rich ways of calling nix with pleasant syntax.

TODO: Intended features

  • Expect tests (pytest-expect-test) or snapshot tests (pytest-insta) or, likely, both! We::jade prefer to have short output written in-line as it makes it greatly easier to read the tests, but pytest-expect doesn't allow for putting larger stuff in external files, so something else is necessary for those.
  • Web server fixture: we don't test our network functionality because background processes are hard and this is simply goofy. We could just test it.
  • Nix daemon fixture.
  • Parallelism via pytest-xdist.