jade
53e0b6ecfb
Mostly these are bugprone-unused-local-non-trivial-variable.
Also fix instances of:
- bugprone-optional-value-conversion
- bugprone-inc-dec-in-conditions (please check this loop is correct, it
is the only non trivial code change in here)
- bugprone-unused-return-value (well, by fixing the lint config)
There are three notable changes relating to undefined vars:
- openLogFile ignoring the result. This is because openLogFile does a
whole bunch of mutation of member variables
- hiliteMatches: i am guessing this is because showing the derivation
name was unhelpful and it just got changed
- canonPath in NarAccessor: canonPath inside of a thing that is supposed
to be vfs based cannot possibly be correct, so let's delete it given
it is unused.
Fixes: #584
Change-Id: I887adc9ff28b61f726dcfed197e6796b414c2fcf
39 lines
1.4 KiB
YAML
39 lines
1.4 KiB
YAML
UseColor: true
|
|
Checks:
|
|
- -*
|
|
- bugprone-*
|
|
# too many warnings
|
|
- -bugprone-assignment-in-if-condition
|
|
# too many warnings
|
|
- -bugprone-narrowing-conversions
|
|
# kind of nonsense
|
|
- -bugprone-easily-swappable-parameters
|
|
# too many warnings for now
|
|
- -bugprone-implicit-widening-of-multiplication-result
|
|
# Lix's exception handling is Questionable
|
|
- -bugprone-empty-catch
|
|
# many warnings
|
|
- -bugprone-unchecked-optional-access
|
|
# many warnings, seems like a questionable lint
|
|
- -bugprone-branch-clone
|
|
# extremely noisy before clang 19: https://github.com/llvm/llvm-project/issues/93959
|
|
- -bugprone-multi-level-implicit-pointer-conversion
|
|
# all thrown exceptions must derive from std::exception
|
|
- hicpp-exception-baseclass
|
|
# capturing async lambdas are dangerous
|
|
- cppcoreguidelines-avoid-capturing-lambda-coroutines
|
|
# crimes must be appropriately declared as crimes
|
|
- cppcoreguidelines-pro-type-cstyle-cast
|
|
- lix-*
|
|
# This can not yet be applied to Lix itself since we need to do source
|
|
# reorganization so that lix/ include paths work.
|
|
- -lix-fixincludes
|
|
# This lint is included as an example, but the lib function it replaces is
|
|
# already gone.
|
|
- -lix-hasprefixsuffix
|
|
|
|
|
|
CheckOptions:
|
|
bugprone-reserved-identifier.AllowedIdentifiers: '__asan_default_options'
|
|
bugprone-unused-return-value.AllowCastToVoid: true
|