jade
0cc285f87b
Fixes:
- Identifiers starting with _ are prohibited
- Some driveby header dependency cleaning which wound up with doing some
extra fixups.
- Fucking C style casts, man. C++ made these 1000% worse by letting you
also do memory corruption with them with references.
- Remove casts to Expr * where ExprBlackHole is an incomplete type by
introducing an explicitly-cast eBlackHoleAddr as Expr *.
- An incredibly illegal cast of the text bytes of the StorePath hash
into a size_t directly. You can't DO THAT.
Replaced with actually parsing the hash so we get 100% of the bits
being entropy, then memcpying the start of the hash. If this shows
up in a profile we should just make the hash parser faster with a
lookup table or something sensible like that.
- This horrendous bit of UB which I thankfully slapped a deprecation
warning on, built, and it didn't trigger anywhere so it was dead
code and I just deleted it. But holy crap you *cannot* do that.
inline void mkString(const Symbol & s)
{
mkString(((const std::string &) s).c_str());
}
- Some wrong lints. Lots of wrong macro lints, one wrong
suspicious-sizeof lint triggered by the template being instantiated
with only pointers, but the calculation being correct for both
pointers and not-pointers.
- Exceptions in destructors strike again. I tried to catch the
exceptions that might actually happen rather than all the exceptions
imaginable. We can let the runtime hard-kill it on other exceptions
imo.
Change-Id: I71761620846cba64d66ee7ca231b20c061e69710
175 lines
5.1 KiB
C++
175 lines
5.1 KiB
C++
#pragma once
|
|
/**
|
|
* @file Reusable serialisers for serialization container types in a
|
|
* length-prefixed manner.
|
|
*
|
|
* Used by both the Worker and Serve protocols.
|
|
*/
|
|
|
|
#include "types.hh"
|
|
#include "serialise.hh"
|
|
|
|
namespace nix {
|
|
|
|
class Store;
|
|
|
|
/**
|
|
* Reusable serialisers for serialization container types in a
|
|
* length-prefixed manner.
|
|
*
|
|
* @param T The type of the collection being serialised
|
|
*
|
|
* @param Inner This the most important parameter; this is the "inner"
|
|
* protocol. The user of this will substitute `MyProtocol` or similar
|
|
* when making a `MyProtocol::Serialiser<Collection<T>>`. Note that the
|
|
* inside is allowed to call to call `Inner::Serialiser` on different
|
|
* types. This is especially important for `std::map` which doesn't have
|
|
* a single `T` but one `K` and one `V`.
|
|
*/
|
|
template<class Inner, typename T>
|
|
struct LengthPrefixedProtoHelper;
|
|
|
|
/*!
|
|
* \typedef LengthPrefixedProtoHelper::S
|
|
*
|
|
* Read this as simply `using S = Inner::Serialise;`.
|
|
*
|
|
* It would be nice to use that directly, but C++ doesn't seem to allow
|
|
* it. The `typename` keyword needed to refer to `Inner` seems to greedy
|
|
* (low precedence), and then C++ complains that `Serialise` is not a
|
|
* type parameter but a real type.
|
|
*
|
|
* Making this `S` alias seems to be the only way to avoid these issues.
|
|
*/
|
|
|
|
#define LENGTH_PREFIXED_PROTO_HELPER(Inner, T) \
|
|
struct LengthPrefixedProtoHelper< Inner, T > \
|
|
{ \
|
|
static T read(const Store & store, typename Inner::ReadConn conn); \
|
|
[[nodiscard]] static WireFormatGenerator write(const Store & store, typename Inner::WriteConn conn, const T & str); \
|
|
private: \
|
|
template<typename U> using S = typename Inner::template Serialise<U>; \
|
|
}
|
|
|
|
template<class Inner, typename T>
|
|
LENGTH_PREFIXED_PROTO_HELPER(Inner, std::vector<T>);
|
|
|
|
template<class Inner, typename T>
|
|
LENGTH_PREFIXED_PROTO_HELPER(Inner, std::set<T>);
|
|
|
|
template<class Inner, typename... Ts>
|
|
LENGTH_PREFIXED_PROTO_HELPER(Inner, std::tuple<Ts...>);
|
|
|
|
template<class Inner, typename K, typename V>
|
|
#define DONT_SUBSTITUTE_KV_TYPE std::map<K, V>
|
|
LENGTH_PREFIXED_PROTO_HELPER(Inner, DONT_SUBSTITUTE_KV_TYPE);
|
|
#undef DONT_SUBSTITUTE_KV_TYPE
|
|
|
|
template<class Inner, typename T>
|
|
std::vector<T>
|
|
LengthPrefixedProtoHelper<Inner, std::vector<T>>::read(
|
|
const Store & store, typename Inner::ReadConn conn)
|
|
{
|
|
std::vector<T> resSet;
|
|
auto size = readNum<size_t>(conn.from);
|
|
while (size--) {
|
|
resSet.push_back(S<T>::read(store, conn));
|
|
}
|
|
return resSet;
|
|
}
|
|
|
|
template<class Inner, typename T>
|
|
WireFormatGenerator
|
|
LengthPrefixedProtoHelper<Inner, std::vector<T>>::write(
|
|
const Store & store, typename Inner::WriteConn conn, const std::vector<T> & resSet)
|
|
{
|
|
co_yield resSet.size();
|
|
for (auto & key : resSet) {
|
|
co_yield S<T>::write(store, conn, key);
|
|
}
|
|
}
|
|
|
|
template<class Inner, typename T>
|
|
std::set<T>
|
|
LengthPrefixedProtoHelper<Inner, std::set<T>>::read(
|
|
const Store & store, typename Inner::ReadConn conn)
|
|
{
|
|
std::set<T> resSet;
|
|
auto size = readNum<size_t>(conn.from);
|
|
while (size--) {
|
|
resSet.insert(S<T>::read(store, conn));
|
|
}
|
|
return resSet;
|
|
}
|
|
|
|
template<class Inner, typename T>
|
|
WireFormatGenerator
|
|
LengthPrefixedProtoHelper<Inner, std::set<T>>::write(
|
|
const Store & store, typename Inner::WriteConn conn, const std::set<T> & resSet)
|
|
{
|
|
co_yield resSet.size();
|
|
for (auto & key : resSet) {
|
|
co_yield S<T>::write(store, conn, key);
|
|
}
|
|
}
|
|
|
|
template<class Inner, typename K, typename V>
|
|
std::map<K, V>
|
|
LengthPrefixedProtoHelper<Inner, std::map<K, V>>::read(
|
|
const Store & store, typename Inner::ReadConn conn)
|
|
{
|
|
std::map<K, V> resMap;
|
|
auto size = readNum<size_t>(conn.from);
|
|
while (size--) {
|
|
auto k = S<K>::read(store, conn);
|
|
auto v = S<V>::read(store, conn);
|
|
resMap.insert_or_assign(std::move(k), std::move(v));
|
|
}
|
|
return resMap;
|
|
}
|
|
|
|
template<class Inner, typename K, typename V>
|
|
WireFormatGenerator
|
|
LengthPrefixedProtoHelper<Inner, std::map<K, V>>::write(
|
|
const Store & store, typename Inner::WriteConn conn, const std::map<K, V> & resMap)
|
|
{
|
|
co_yield resMap.size();
|
|
for (auto & i : resMap) {
|
|
co_yield S<K>::write(store, conn, i.first);
|
|
co_yield S<V>::write(store, conn, i.second);
|
|
}
|
|
}
|
|
|
|
template<class Inner, typename... Ts>
|
|
std::tuple<Ts...>
|
|
LengthPrefixedProtoHelper<Inner, std::tuple<Ts...>>::read(
|
|
const Store & store, typename Inner::ReadConn conn)
|
|
{
|
|
return std::tuple<Ts...> {
|
|
S<Ts>::read(store, conn)...,
|
|
};
|
|
}
|
|
|
|
template<class Inner, typename... Ts>
|
|
WireFormatGenerator
|
|
LengthPrefixedProtoHelper<Inner, std::tuple<Ts...>>::write(
|
|
const Store & store, typename Inner::WriteConn conn, const std::tuple<Ts...> & res)
|
|
{
|
|
auto fullArgs = std::apply(
|
|
[&](auto &... rest) {
|
|
return std::tuple<const Store &, typename Inner::WriteConn &, const Ts &...>(
|
|
std::cref(store), conn, rest...
|
|
);
|
|
},
|
|
res
|
|
);
|
|
return std::apply(
|
|
[]<typename... Us>(auto & store, auto conn, const Us &... args) -> WireFormatGenerator {
|
|
(co_yield S<Us>::write(store, conn, args), ...);
|
|
},
|
|
fullArgs
|
|
);
|
|
}
|
|
|
|
}
|