lix/src
Aniket Deshpande ec58ba38c5
Fix http2 = false having no effect. Fixes #2971.
Setting `http2 = false` in nix config (e.g. /etc/nix/nix.conf)
had no effect, and `nix-env -vvvvv -i hello` still downloaded .nar
packages using HTTP/2.

In `src/libstore/download.cc`, the `CURL_HTTP_VERSION_2TLS` option was
being explicitly set when `downloadSettings.enableHttp2` was `true`,
but, `CURL_HTTP_VERSION_1_1` option was not being explicitly set when
`downloadSettings.enableHttp2` was `false`.

This may be because `https://curl.haxx.se/libcurl/c/libcurl-env.html` states:
"You have to set this option if you want to use libcurl's HTTP/2 support."
but, also, in the changelog, states:
"DEFAULT
Since curl 7.62.0: CURL_HTTP_VERSION_2TLS
Before that: CURL_HTTP_VERSION_1_1"

So, the default setting for `libcurl` is HTTP/2 for version >= 7.62.0.

In this commit, option `CURLOPT_HTTP_VERSION` is explicitly set to
`CURL_HTTP_VERSION_1_1` when `downloadSettings.enableHttp2` nix config
setting is `false`.

This can be tested by running `nix-env -vvvvv -i hello | grep HTTP`
2019-06-28 20:44:46 +05:30
..
build-remote canBuildLocally: check for features 2019-03-06 05:03:25 +00:00
cpptoml bump cpptoml to v0.1.1 2019-05-29 17:01:39 +08:00
libexpr Fix 32-bit overflow with --no-net 2019-06-24 22:16:43 +02:00
libmain Automatically use --no-net if there are no network interfaces 2019-06-25 12:45:59 +02:00
libstore Fix http2 = false having no effect. Fixes #2971. 2019-06-28 20:44:46 +05:30
libutil Add "warning" verbosity level 2019-06-25 12:44:17 +02:00
nix Fix macOS build failure 2019-06-28 15:38:23 +02:00
nix-build nix-shell: Don't absolutize '-p' expressions 2019-05-08 14:29:36 +02:00
nix-channel nix-channel: Don't fetch binary-cache-url 2019-06-25 13:27:16 +02:00
nix-collect-garbage Merge all nix-* binaries into nix 2018-10-26 12:54:00 +02:00
nix-copy-closure Merge all nix-* binaries into nix 2018-10-26 12:54:00 +02:00
nix-daemon Style fix 2019-06-16 09:43:20 +02:00
nix-env Merge all nix-* binaries into nix 2018-10-26 12:54:00 +02:00
nix-instantiate Merge all nix-* binaries into nix 2018-10-26 12:54:00 +02:00
nix-prefetch-url nix-prefetch-url: Stop progress bar before printing results 2018-11-09 10:34:12 +01:00
nix-store nix-store --gc --print-roots: Sort output 2019-03-14 13:59:10 +01:00
nlohmann nlohmann-json: 3.4.0 -> 3.5.0 2018-12-21 22:38:06 -06:00
resolve-system-dependencies Remove mentions of libformat, it no longer exists 2019-01-05 14:31:29 -05:00